Bos Wars - Patches: patch #7070, Fix buffer overflow in...
You are not allowed to post comments on this tracker with your current authentication level.
patch #7070: Fix buffer overflow in unit->Data.Move.Path[]
Submitter: | Kalle Olavi Niemitalo <kon> | ||
Submitted: | Thu 21 Jan 2010 08:31:47 PM UTC | ||
Open/Closed: | Closed | Status: | Done |
Assigned to: | feb |
Sun 28 Feb 2010 04:22:01 PM UTC, comment #2: |
François Beerten <feb> |
Thu 21 Jan 2010 09:37:50 PM UTC, comment #1: First patch applied. |
François Beerten <feb> |
Thu 21 Jan 2010 08:31:47 PM UTC, original submission:
When saving a game, save unit->Data.Move only if the current order seems to use that. In particular, don't save it when the action of the current order is UnitActionDie (which doesn't use any data), nor when the unit hasn't yet started executing the current order. This fix is incomplete in that it never saves unit->Data.Move for UnitActionResource, even though that does use it for some values of unit->SubAction; but this is not a new bug.
|
Kalle Olavi Niemitalo <kon> |
Depends on the following items: None found
Items that depend on this one: None found
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2010-02-28 | feb | Open/Closed | Open | Closed | |
Status | In Progress | Done | |||
2010-01-21 | feb | Status | None | In Progress | |
Assigned to | None | feb | |||
2010-01-21 | kon | Attached File | - | Added 0001-Split-SaveOrderData-off-SaveUnit.patch, #19523 | |
Attached File | - | Added 0002-Fix-buffer-overflow-in-unit-Data.Move.Path.patch, #19524 |
Powered by Savane 3.13-caa5.
Corresponding source code
Second patch applied.
Thank you for the patches.