patchAVR C Runtime Library - Patches: patch #7146, #bug28901 - Xmega header files...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7146: #bug28901 - Xmega header files with missing definitions for GPIO_t and CPU_t

Submitter:  Anitha Boyapati <aboyapati>
Submitted:  Tue 30 Mar 2010 03:26:31 PM UTC
   
 
Category:  None Priority:  9 - Immediate
Status:  Done Privacy:  Public
Assigned to:  aboyapati Open/Closed:  Closed

Mon 05 Apr 2010 10:09:56 PM UTC, comment #3: 

Patch looks good, please commit.

And next time you can submit the patch directly to the bug report that it is associated with, instead of a separate Patch tracker.

Eric Weddington <arcanum>
Group administrator
Wed 31 Mar 2010 06:09:13 AM UTC, comment #2: 


> - You also need to make the changes to iox64a1u.h.


I think this file has been recently committed and didn't find it in my working copy. Once I did an update, I found it.

Thanks for the review Eric. I have addressed all issues and re-submitted the patch.




Anitha Boyapati <aboyapati>
Wed 31 Mar 2010 04:19:42 AM UTC, comment #1: 

Changes needed to this patch:

- You have accidentally removed the CLK_t structure definition in iox128a1.h. Please put this back in.

- ChangeLog entry. Please write the word 'ditto' or 'same' to each file that has the same change as the file above it, see example below. Also each comment must be a complete sentence, i.e. end it in a period.

--- ChangeLog (revision 2103)
+++ ChangeLog (working copy)
@@ -1,3 +1,23 @@
+2010-03-31  Anitha Boyapati <anitha.boyapati@atmel.com>
+
+ Fix bug #28901.
+ * include/avr/iox128a1.h - Removed GPIO and CPU memory map entries.
+ * include/avr/iox128a1u.h - Same.
+ * include/avr/iox128a3.h - Same.
+ * include/avr/iox128d3.h - Same.
+ * include/avr/iox16a4.h - Same.
+ * include/avr/iox16d4.h - Same.
+ * include/avr/iox192a3.h - Same.
+ * include/avr/iox192d3.h - Same.
+ * include/avr/iox256a3.h - Same.
+ * include/avr/iox256a3b.h - Same.
+ * include/avr/iox256d3.h - Same.
+ * include/avr/iox32a4.h - Same.
+ * include/avr/iox32d4.h - Same.
+ * include/avr/iox64a1.h - Same.
+ * include/avr/iox64a3.h - Same.
+ * include/avr/iox64d3.h - Same.
+

- You also need to make the changes to iox64a1u.h.

- In the NEWS entry, the description of the bug is the "Summary" field description on the bug report, so instead of this:

--- NEWS (revision 2103)
+++ NEWS (working copy)
@@ -108,6 +108,7 @@
   [#28688] using_tools.dox fails to build due to extra underscore
   [#28756] Bug in AVR libc 1.6.7 (power.h for 8-bit AVR)
   [#28812] iotn48.h TWS# bits off by one
+  [#28901] iox*.h are modified as a part of bug28901 fix


It should be this:

--- NEWS (revision 2103)
+++ NEWS (working copy)
@@ -108,6 +108,7 @@
   [#28688] using_tools.dox fails to build due to extra underscore
   [#28756] Bug in AVR libc 1.6.7 (power.h for 8-bit AVR)
   [#28812] iotn48.h TWS# bits off by one
+  [#28901] Xmega header files are missing definitions for GPIO_t and CPU_t

Eric Weddington <arcanum>
Group administrator
Tue 30 Mar 2010 03:26:31 PM UTC, original submission:  


Anitha Boyapati <aboyapati>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #20070:  bug28901.patch added by aboyapati (17KiB - application/octet-stream - New patch created addressing the comments from Eric)
file #20066:  bug28901.patch added by aboyapati (17KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by arcanum (Posted a comment)
  • -email is unavailable- added by aboyapati (Submitted the item)
  • -email is unavailable- added by aboyapati
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-04-14 aboyapati StatusReady For Test Done
        Open/ClosedOpen Closed
    2010-03-31 aboyapati Attached File- Added bug28901.patch, #20070
    2010-03-30 aboyapati Attached File- Added bug28901.patch, #20066
        Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code