patchmldonkey, a multi-networks file-sharing client - Patches: patch #7167, Improve add_mail_brackets option...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7167: Improve add_mail_brackets option description, change default according to RFC

Submitter:  Mehdi Dogguy <mehdid>
Submitted:  Sun 18 Apr 2010 11:18:49 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Sun 25 Apr 2010 01:17:47 PM UTC, comment #3: 

committed 2010/04/25

spiralvoice <spiralvoice>
Group administrator
Sun 18 Apr 2010 11:18:49 AM UTC, comment #2: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client bugs tracker to your tracker.

The original report is still available at bugs #27907

Following are the information included in the original report:

[field #0]                  Item ID: 27907
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #8]                         : Unknown bugs Field Display Type
[field #9]                 Category: None
[field #10]             Submitted by: mehdid
[field #11]              Assigned to: None
[field #12]             Submitted on: Sun 01 Nov 2009 10:10:51 PM CET
[field #13]                  Summary: Improve add_mail_brackets option description, change default according to RFC
[field #14]      Original Submission: The add_mail_brackets option seems wrongly defined. It defaults to false and the description says "Does your mail-server need <...> around addresses", suggesting that it's a workaround. RFC 5321, however, specifies that these brackets are required:

  4.1.2. Command Argument Syntax

  […]
  Reverse-path   = Path / "<>"
  Forward-path   = Path
  Path           = "<" [ A-d-l ":" ] Mailbox ">"
  […]

The default should thus be true and the description "set to false if your mail server does not know how to handle angle-brackets around addresses (RFC 5321)".

Ideally, the option should be removed and replaced with
"omit_mail_brackets", defaulting to false and with description "set to true if your mail server does not implement RFC 5321 correctly and cannot handle angle-brackets around addresses."

Source: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=544175 />[field #16]               Item Group: Feature request
[field #17]                   Status: None
[field #18]        Component Version: None
[field #19]         Operating System: None
[field #20]          Reproducibility: None
[field #21]               Size (loc): None
[field #22]            Fixed Release: None
[field #23]          Planned Release: None
[field #24]                   Effort: 0.00
[field #28]                 Priority: 5 - Normal
[field #31]         Percent Complete: 0%
[field #33]                  Release: 3.0.1
[field #58]          Binaries Origin: None
[field #59]                 CPU type: Intel x86
[field #60]                      CPU: None
[field #61]     Custom Select Box #4: None
[field #62]     Custom Select Box #5: None
[field #63]     Custom Select Box #6: None
[field #64]     Custom Select Box #7: None
[field #65]     Custom Select Box #8: None
[field #66]     Custom Select Box #9: None
[field #67]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Group administrator
Sat 10 Apr 2010 07:04:59 PM UTC, comment #1: 

bump.
Looks reasonable.

ygrek <ygrek>
Group Member
Sun 18 Apr 2010 11:18:49 AM UTC, original submission:  

The add_mail_brackets option seems wrongly defined. It defaults to false and the description says "Does your mail-server need <...> around addresses", suggesting that it's a workaround. RFC 5321, however, specifies that these brackets are required:

  4.1.2. Command Argument Syntax

  […]
  Reverse-path   = Path / "<>"
  Forward-path   = Path
  Path           = "<" [ A-d-l ":" ] Mailbox ">"
  […]

The default should thus be true and the description "set to false if your mail server does not know how to handle angle-brackets around addresses (RFC 5321)".

Ideally, the option should be removed and replaced with
"omit_mail_brackets", defaulting to false and with description "set to true if your mail server does not implement RFC 5321 correctly and cannot handle angle-brackets around addresses."

Source: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=544175

Mehdi Dogguy <mehdid>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #20267:  add_mail_brackets.diff added by ygrek (675B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by spiralvoice (Updated the item)
  • -email is unavailable- added by ygrek (Posted a comment)
  • -email is unavailable- added by mehdid (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-04-25 spiralvoice StatusNone Done
        Open/ClosedOpen Closed
    2010-04-18 spiralvoice Reassign itemmldonkey, a multi-networks file-sharing client, bug #27907 mldonkey, a multi-networks file-sharing client, patch #7167

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code