patchmldonkey, a multi-networks file-sharing client - Patches: patch #7181, HTML: Fix sorting of friends' file...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7181: HTML: Fix sorting of friends' file list

Submitter:  Sergey Svishchev <shattered>
Submitted:  Sun 02 May 2010 07:35:26 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Sun 23 May 2010 09:05:23 AM UTC, comment #4: 

committed 2010/05/23

spiralvoice <spiralvoice>
Group administrator
Sun 02 May 2010 07:35:26 AM UTC, comment #3: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client bugs tracker to your tracker.

The original report is still available at bugs #22622

Following are the information included in the original report:

[field #0]                  Item ID: 22622
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #8]                         : Unknown bugs Field Display Type
[field #9]                 Category: HTTP interface
[field #10]             Submitted by: shattered
[field #11]              Assigned to: None
[field #12]             Submitted on: So 16 Mär 2008 19:25:47 CET
[field #13]                  Summary: Friends' file list cannot be sorted by name correctly
[field #14]      Original Submission: print_results() in src/daemon/driver/driverInteractive.ml sorts not the names themselves (inside the ), but entire HTML fragments, which include file ID.
[field #16]               Item Group: None
[field #17]                   Status: None
[field #18]        Component Version: None
[field #19]         Operating System: None
[field #20]          Reproducibility: None
[field #21]               Size (loc): None
[field #22]            Fixed Release: None
[field #23]          Planned Release: None
[field #24]                   Effort: 0.00
[field #28]                 Priority: 5 - Normal
[field #31]         Percent Complete: 0%
[field #33]                  Release: 2.9.3
[field #58]          Binaries Origin: None
[field #59]                 CPU type: None
[field #60]                      CPU: None
[field #61]     Custom Select Box #4: None
[field #62]     Custom Select Box #5: None
[field #63]     Custom Select Box #6: None
[field #64]     Custom Select Box #7: None
[field #65]     Custom Select Box #8: None
[field #66]     Custom Select Box #9: None
[field #67]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Group administrator
Sat 01 May 2010 06:54:09 AM UTC, comment #2: 

Actually the fix is quite simple: get the inner text of the node instead of inner html.

(file #20381)

ygrek <ygrek>
Group Member
Wed 28 Apr 2010 07:14:07 PM UTC, comment #1: 

fwiw, sorting is done on js side by _tabSort in commonMessages.ml (it takes innerHTML hence the result), cannot think of easy way to fix this..

ygrek <ygrek>
Group Member
Sun 02 May 2010 07:35:26 AM UTC, original submission:  

print_results() in src/daemon/driver/driverInteractive.ml sorts not the names themselves (inside the <a href></a>), but entire HTML fragments, which include file ID.

Sergey Svishchev <shattered>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #20381:  bug_22622.diff added by ygrek (1KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by spiralvoice (Posted a comment)
  • -email is unavailable- added by ygrek (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-05-23 spiralvoice StatusNone Done
        Open/ClosedOpen Closed
        SummaryFriends\' file list cannot be sorted by name correctly HTML: Fix sorting of friends' file list
    2010-05-02 spiralvoice Reassign itemmldonkey, a multi-networks file-sharing client, bug #22622 mldonkey, a multi-networks file-sharing client, patch #7181

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code