patchmldonkey, a multi-networks file-sharing client - Patches: patch #7204, dump memory statistics to file

 
 

You are not allowed to post comments on this tracker with your current authentification level.

patch #7204: dump memory statistics to file

Submitted by:  ygrek <ygrek>
Submitted on:  Mon 24 May 2010 09:24:30 PM UTC  
 
Category: Improved interfacesPriority: 5 - Normal
Status: PostponedAssigned to: ygrek <ygrek>
Open/Closed: Open

Sat 23 Oct 2010 06:51:46 PM UTC, comment #4:

I think we can leave it uncommited, it was used simply as a quick hack to view memory usage and I didn't want to throw away code - maybe it will be needed again some day.

ygrek <ygrek>
Project MemberIn charge of this item.
Sat 23 Oct 2010 06:46:08 PM UTC, comment #3:

At least one compilation error is still left:

File "src/daemon/common/commonSources.ml", line 2030, characters 32-35:
This expression has type
string -> [ `F of float | `I of int | `S of string | `X ] -> unit
but is here used with type Buffer.t

spiralvoice <spiralvoice>
Project Administrator
Sat 23 Oct 2010 06:45:32 PM UTC, comment #2:

Yet another patch to fix compilation error:

--- src/daemon/common/commonHosts.ml 2010-10-23 20:45:06.000000000 +0200
+++ src/daemon/common/commonHosts.ml 2005-09-19 12:09:05.000000000 +0200
@@ -93,9 +93,9 @@

let hosts_by_key = Hashtbl.create 103

- let () =
- Heap.add_memstat "CommonHosts" (fun _level k ->
- k "hosts_by_key" (`I (Hashtbl.length hosts_by_key));
+ let _ =
+ Heap.add_memstat "CommonHosts" (fun level buf ->
+ Printf.bprintf buf " hosts_by_key: %d\n" (Hashtbl.length hosts_by_key);
)

spiralvoice <spiralvoice>
Project Administrator
Sat 23 Oct 2010 06:44:24 PM UTC, comment #1:

this is patch is needed to allow GUI compilation:

--- config/Makefile.in<>2010-10-19 19:30:54.000000000 +0200
+++ config/Makefile.in<>2010-10-23 20:37:50.000000000 +0200
@@ -148,9 +148,9 @@
.
.
CDK_SRCS+= $(LIB)/fifo.ml $(CDK)/arg2.ml $(LIB)/syslog.ml $(CDK)/printf2.ml \
- $(CDK)/heap.ml \
$(CDK)/printexc2.ml $(CDK)/genlex2.ml \
$(CDK)/filepath.ml $(CDK)/string2.ml \
+ $(CDK)/heap.ml \
$(CDK)/filename2.ml $(CDK)/list2.ml $(CDK)/hashtbl2.ml \
$(CDK)/unix2.ml $(CDK)/file.ml \
$(CDK)/heap_c.c $(CDK)/array2.ml

spiralvoice <spiralvoice>
Project Administrator
Mon 24 May 2010 09:24:30 PM UTC, original submission:

see http://mldonkey.sourceforge.net/phpBB2/viewtopic.php?t=5459&start=15

ygrek <ygrek>
Project MemberIn charge of this item.

 

Attached Files
file #20609:  mem_stats.diff added by ygrek (32kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by spiralvoice (Posted a comment)
  • -unavailable- added by ygrek (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 23 Oct 2010 06:59:07 PM UTCspiralvoiceStatusIn Progress=>Postponed
    Sat 23 Oct 2010 06:44:24 PM UTCspiralvoiceCategoryNone=>Improved interfaces
      StatusNone=>In Progress
    Mon 24 May 2010 09:24:30 PM UTCygrekAttached File-=>Added mem_stats.diff, #20609

    Back to the top


    Powered by Savane 3.1-cleanup