patchmldonkey, a multi-networks file-sharing client - Patches: patch #7219, fsync rename options files

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7219: fsync rename options files

Submitter:  ygrek <ygrek>
Submitted:  Sun 13 Jun 2010 02:59:53 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Assigned to:  ygrek
Open/Closed:  Closed

Fri 16 Jul 2010 01:56:46 PM UTC, comment #2: 

committed 2010/07/16

spiralvoice <spiralvoice>
Group administrator
Fri 18 Jun 2010 08:38:27 PM UTC, comment #1: 
ygrek <ygrek>
Group Member
Sun 13 Jun 2010 02:59:53 PM UTC, original submission:  

Looking at the options code, it appears that temp-rename pattern is used, but without fsync. AFAIK this can lead to file corruption if machine crashes/loses power except when filesystem is 'ext3 data=ordered'.

ygrek <ygrek>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #20786:  fsync_rename2.diff added by ygrek (3KiB - text/x-diff)
file #20745:  fsync_rename.diff added by ygrek (1KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by spiralvoice (Posted a comment)
  • -email is unavailable- added by ygrek (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-07-16 spiralvoice StatusReady For Test Done
        Open/ClosedOpen Closed
    2010-06-18 ygrek Attached File- Added fsync_rename2.diff, #20786
    2010-06-13 ygrek Attached File- Added fsync_rename.diff, #20745

    Back to the top

    Powered by Savane 3.13-0329.
    Corresponding source code