patchmldonkey, a multi-networks file-sharing client - Patches: patch #7280, BT : make_torrent creates...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7280: BT : make_torrent creates sometimes torrents without name argument

Submitter:  Rebel2k <rebel2k>
Submitted:  Sun 15 Aug 2010 11:40:14 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Sun 15 Aug 2010 03:05:26 PM UTC, comment #5: 

committed 2010/08/15

spiralvoice <spiralvoice>
Group administrator
Sun 15 Aug 2010 11:40:14 AM UTC, comment #4: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client bugs tracker to your tracker.

The original report is still available at bugs #14150

Following are the information included in the original report:

[field #0]                  Item ID: 14150
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #9]                 Category: Bittorrent-Plugin
[field #10]             Submitted by: rebel2k
[field #11]              Assigned to: None
[field #12]             Submitted on: Tue 16 Aug 2005 09:20:55 PM GMT
[field #13]                  Summary: BT : make_torrent creates sometimes torrents without name argument
[field #14]      Original Submission: I have observed a bad behavior of make_torrent.
When a multifile torrent should be created users have exactly to look that they do not append an ending / in the command line while creating a torrent. If then did not, the finished torrent gets a bad torrent "name"

this example should show what happend when I create an torrent:

1.
./make_torrent -tracker "www.mldonkey.net" -torrent donitor.torrent -create donitor/

when checking with
./make_torrent -torrent donitor.torrent -print

output is:
-----
home@server:/home/mldonkey # ./make_torrent -torrent donitor.torrent -print
2005/08/16 23:08:48 Starting MLDonkey 2.6.1 ...
2005/08/16 23:08:48 Language DE, locale ISO-8859-15
2005/08/16 23:08:48 MLDonkey is working in .
2005/08/16 23:08:48 [DNS]: Resolving [server] ...
Torrent name: .
        comment: Created by MLdonkey/2.6.2.CVS
        created by: MLdonkey/2.6.2.CVS
        creation date: 23:08  Tue 16 Aug
        modified by:
        length: 351775
        encoding:
        tracker: www.mldonkey.net
        private: 0
        piece size: 262144
  Pieces: 2
      0: WVER2KDOAGQVFCKVDDHDIQEUBSSXHPBF
      1: EYROJMGDENVQG5MFWCNYPPSVJTPCW4UC
  Files: 22
            53 : dbase/README.txt
        272560 : dbase/esel.rrd
            37 : dbase/totals.csv
          1215 : ABOUT.txt
          2240 : CHANGELOG.txt
          3259 : INSTALL.txt
           379 : UPDATE.txt
         11839 : sbin/update_rrd.pl
         11833 : sbin/update_rrd.pl_org
            78 : tmp/README.txt
            78 : www/images/README.txt
          1920 : www/images/esel.gif
          5258 : www/images/last12h.gif
          4979 : www/images/last2d.gif
          4728 : www/images/last32d.gif
          4369 : www/images/last8d.gif
          2799 : www/images/peers.gif
          3749 : www/images/protocol.gif
          4160 : www/images/workload.gif
           242 : www/index.html
          8000 : www/monitor.cgi
          8000 : www/monitor.cgi_org
--------

have a look on "Torrent name: . "

2. now let create the torrent like:
./make_torrent -tracker "www.mldonkey.net" -torrent donitor.torrent -create donitor

and -print shows now the right output:
-----
home@server:/home/mldonkey # ./make_torrent -torrent donitor.torrent -print
2005/08/16 23:12:25 Starting MLDonkey 2.6.1 ...
2005/08/16 23:12:25 Language DE, locale ISO-8859-15
2005/08/16 23:12:25 MLDonkey is working in .
2005/08/16 23:12:25 [DNS]: Resolving [server] ...
Torrent name: donitor
        comment: Created by MLdonkey/2.6.2.CVS
        created by: MLdonkey/2.6.2.CVS
        creation date: 23:12  Tue 16 Aug
        modified by:
        length: 351775
        encoding:
        tracker: www.mldonkey.net
        private: 0
        piece size: 262144
  Pieces: 2
      0: WVER2KDOAGQVFCKVDDHDIQEUBSSXHPBF
      1: EYROJMGDENVQG5MFWCNYPPSVJTPCW4UC
  Files: 22
-----

Torrent name now is right >> donitor

Now, is it a littel bug ? when not it should be mentioned in make_torrent --help

P.S: what das private: 0/1 mean?

[field #16]               Item Group: None
[field #17]                   Status: None
[field #18]        Component Version: None
[field #19]         Operating System: Linux
[field #20]          Reproducibility: None
[field #21]               Size (loc): None
[field #22]            Fixed Release: None
[field #23]          Planned Release: None
[field #24]                   Effort: 0.00
[field #28]                 Priority: 5 - Normal
[field #31]         Percent Complete: 0%
[field #33]                  Release: 2.7.7
[field #34]                  Release: 2.6.2
[field #58]          Binaries Origin: CVS / Self compiled
[field #59]                 CPU type: Intel x86
[field #60]                      CPU: None
[field #61]     Custom Select Box #4: None
[field #62]     Custom Select Box #5: None
[field #63]     Custom Select Box #6: None
[field #64]     Custom Select Box #7: None
[field #65]     Custom Select Box #8: None
[field #66]     Custom Select Box #9: None
[field #67]    Custom Select Box #10: None

ygrek <ygrek>
Group Member
Sun 15 Aug 2010 11:40:08 AM UTC, comment #3: 

The same patch with more descriptive error message.

(file #21222)

ygrek <ygrek>
Group Member
Mon 17 Jul 2006 07:51:56 AM UTC, comment #2: 

I get an error when try to crate an torrent wiht this little patch:

-------------------
2006/07/17 09:50:04 Starting MLDonkey 2.7.7.CVS ...
2006/07/17 09:50:04 Language DE, locale ISO-8859-15, ulimit for open files 1024
2006/07/17 09:50:04 MLDonkey is working in .
2006/07/17 09:50:04 Loading language resource mlnet_strings.en
2006/07/17 09:50:04 loaded language resource file
2006/07/17 09:50:04 [DNS] Resolving [h41439] ...
Fatal error: exception Assert_failure("src/utils/lib/unix32.ml", 424, 16)
h41439:/home/mldonkey/test #

Rebel2k <rebel2k>
Thu 29 Jun 2006 11:34:15 PM UTC, comment #1: 

Please test the attached patch, also for torrents which were
created well before.

spiralvoice <spiralvoice>
Group administrator
Sun 15 Aug 2010 11:40:14 AM UTC, original submission:  

I have observed a bad behavior of make_torrent.
When a multifile torrent should be created users have exactly to look that they do not append an ending / in the command line while creating a torrent. If then did not, the finished torrent gets a bad torrent "name"

this example should show what happend when I create an torrent:

1.
./make_torrent -tracker "www.mldonkey.net" -torrent donitor.torrent -create donitor/

when checking with
./make_torrent -torrent donitor.torrent -print

output is:
-----
home@server:/home/mldonkey # ./make_torrent -torrent donitor.torrent -print
2005/08/16 23:08:48 Starting MLDonkey 2.6.1 ...
2005/08/16 23:08:48 Language DE, locale ISO-8859-15
2005/08/16 23:08:48 MLDonkey is working in .
2005/08/16 23:08:48 [DNS]: Resolving [server] ...
Torrent name: .
        comment: Created by MLdonkey/2.6.2.CVS
        created by: MLdonkey/2.6.2.CVS
        creation date: 23:08  Tue 16 Aug
        modified by:
        length: 351775
        encoding:
        tracker: www.mldonkey.net
        private: 0
        piece size: 262144
  Pieces: 2
      0: WVER2KDOAGQVFCKVDDHDIQEUBSSXHPBF
      1: EYROJMGDENVQG5MFWCNYPPSVJTPCW4UC
  Files: 22
            53 : dbase/README.txt
        272560 : dbase/esel.rrd
            37 : dbase/totals.csv
          1215 : ABOUT.txt
          2240 : CHANGELOG.txt
          3259 : INSTALL.txt
           379 : UPDATE.txt
         11839 : sbin/update_rrd.pl
         11833 : sbin/update_rrd.pl_org
            78 : tmp/README.txt
            78 : www/images/README.txt
          1920 : www/images/esel.gif
          5258 : www/images/last12h.gif
          4979 : www/images/last2d.gif
          4728 : www/images/last32d.gif
          4369 : www/images/last8d.gif
          2799 : www/images/peers.gif
          3749 : www/images/protocol.gif
          4160 : www/images/workload.gif
           242 : www/index.html
          8000 : www/monitor.cgi
          8000 : www/monitor.cgi_org
--------

have a look on "Torrent name: . "

2. now let create the torrent like:
./make_torrent -tracker "www.mldonkey.net" -torrent donitor.torrent -create donitor

and -print shows now the right output:
-----
home@server:/home/mldonkey # ./make_torrent -torrent donitor.torrent -print
2005/08/16 23:12:25 Starting MLDonkey 2.6.1 ...
2005/08/16 23:12:25 Language DE, locale ISO-8859-15
2005/08/16 23:12:25 MLDonkey is working in .
2005/08/16 23:12:25 [DNS]: Resolving [server] ...
Torrent name: donitor
        comment: Created by MLdonkey/2.6.2.CVS
        created by: MLdonkey/2.6.2.CVS
        creation date: 23:12  Tue 16 Aug
        modified by:
        length: 351775
        encoding:
        tracker: www.mldonkey.net
        private: 0
        piece size: 262144
  Pieces: 2
      0: WVER2KDOAGQVFCKVDDHDIQEUBSSXHPBF
      1: EYROJMGDENVQG5MFWCNYPPSVJTPCW4UC
  Files: 22
-----

Torrent name now is right >> donitor

Now, is it a littel bug ? when not it should be mentioned in make_torrent --help

P.S: what das private: 0/1 mean?

Rebel2k <rebel2k>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #21222:  make_torrent.diff added by ygrek (3KiB - text/x-patch)
file #10278:  make_torrent.patch added by spiralvoice (658B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by spiralvoice (Posted a comment)
  • -email is unavailable- added by ygrek (Updated the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-08-15 spiralvoice StatusNone Done
        Open/ClosedOpen Closed
    2010-08-15 ygrek Reassign itemmldonkey, a multi-networks file-sharing client, bug #14150 mldonkey, a multi-networks file-sharing client, patch #7280

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code