patchmldonkey, a multi-networks file-sharing client - Patches: patch #7309, GUI protocol: add opcode to...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

patch #7309: GUI protocol: add opcode to retrieve servers list

Submitted by:  ygrek <ygrek>
Submitted on:  Tue 07 Sep 2010 08:56:55 PM UTC  
 
Category: Improved interfacesPriority: 5 - Normal
Status: Need InfoAssigned to: None
Open/Closed: Open

Mon 13 Sep 2010 04:37:37 PM UTC, comment #5:

In HTML interface there exists a column "P". Also the option ED2K-connect_only_preferred_server should be made a global option to be used by DC as well.
For displaying large HTML content see bug #17712.

spiralvoice <spiralvoice>
Project Administrator
Sun 12 Sep 2010 09:24:50 PM UTC, comment #4:

Ok, I will move hublist to CommonServers and see whther it is usable - browser will have a hard time coping with 1.5k entries table, also the question is how the chosen/favorite servers are distinguished in this list.

ygrek <ygrek>
Project Member
Wed 08 Sep 2010 07:57:43 PM UTC, comment #3:

"GuiServerInfo is for connected/chosen servers only."

Afair no, my EDK server list shows all known servers, regardless of connection state. But now I remember my IRC log from 2007 (long time ago...) on the Wiki from my talk with the original coder of the DC++ code:
http://mldonkey.sourceforge.net/DirectConnect

Apr 30 22:08:41 <Alffa> if you list the hublist there is add button
Apr 30 22:09:00 <Alffa> when yuou add the hub it shows in global servers list
Apr 30 22:10:44 <spiralvoice> Alffa: I added 8 hubs, thry are all in state waiting now, should I add more hubs?
Apr 30 22:11:19 <Alffa> the "waiting" means that the server/hub is like in your favourites list and doing nothing
Apr 30 22:12:21 <Alffa> you have to connect to it from global server ist and if it connects it shows in global servers list "connected" and in dc hub list "user" or "op"
Apr 30 22:13:08 <Alffa> there is no limit for hubs, you can add as meny you think are usable to you
Apr 30 22:13:16 <Alffa> like favourites list ...

This means DC++ has a second list of servers, outside CommonServer, where a loaded hublist is stored first. From there you have to manually add a server (aka hub) to CommonServer and use it.
Now I understand the problem you want to solve, but I do not think having a second server list, specific to one network, is such a good idea.
Did you already talk to zet (Sancho maintainer) about your proposal?
Or did you try storing a hublist directly in CommonServer? G2 and Fasttrack work that way and I do not remember performance problems with hundreds of servers.

spiralvoice <spiralvoice>
Project Administrator
Wed 08 Sep 2010 07:28:20 PM UTC, comment #2:

GuiServerInfo is for connected/chosen servers only. This list is intended to be presented to user to choose servers from - e.g. dchublist contains the list of all known public DC hubs (currently 1500) - for now this list is only accessible via webui or telnet. I was thinking of reusing Server_info fir this too but then it would have contained many dummy values and so I have chosen more free-form structure. Maybe a better name should be used.

ygrek <ygrek>
Project Member
Wed 08 Sep 2010 04:39:44 PM UTC, comment #1:

What is the purpose of this patch?

All servers present are currently sent by update_gui_info() to the GUI which then can distinguish servers by their network identifier:
http://mldonkey.sourceforge.net/GuiServerInfo

spiralvoice <spiralvoice>
Project Administrator
Tue 07 Sep 2010 08:56:55 PM UTC, original submission:

currently implemented for DC

(this and previous patches are from dev/3.0.5 branch from the git repo)

ygrek <ygrek>
Project Member

 

Attached Files
file #21408:  gui_serverslist.diff added by ygrek (11kB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by spiralvoice (Posted a comment)
  • -unavailable- added by ygrek (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 08 Sep 2010 04:39:44 PM UTCspiralvoiceCategoryNone=>Improved interfaces
      StatusNone=>Need Info
    Tue 07 Sep 2010 08:56:55 PM UTCygrekAttached File-=>Added gui_serverslist.diff, #21408

    Back to the top


    Powered by Savane 3.1-cleanup