patchGnome Chemistry Utils - Patches: patch #7677, 0.13.5 won't build with...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

patch #7677: 0.13.5 won't build with LDFLAGS="-Wl,--no-undefined"

Submitted by:  Funda Wang <fundawang>
Submitted on:  Sun 27 Nov 2011 04:14:52 PM UTC  
 
Category: NonePriority: 6
Status: DonePrivacy: Public
Assigned to: Jean Bréfort <jean_brefort>Open/Closed: Closed

Mon 28 Nov 2011 06:30:38 AM UTC, comment #5:

Fixed in trunk.

Jean Bréfort <jean_brefort>
Project AdministratorIn charge of this item.
Sun 27 Nov 2011 07:10:09 PM UTC, comment #4:

The two other patches are applied (not commited yet). I have no more gtk_ or gdk_ (except gdk_pixbuf) direct calls in gcu. Just gcu might still have gtk in its dependance due to goffice.

Jean Bréfort <jean_brefort>
Project AdministratorIn charge of this item.
Sun 27 Nov 2011 06:02:33 PM UTC, comment #3:

There are some other patches in the same place, maybe you should give a look also:

gnome-chemistry-utils-0.13.5-glib.patch:
Fix build with latest glib.

gnome-chemistry-utils-0.13.5-install.patch:
Remove extra DESTDIR when installing pixmaps.

Funda Wang <fundawang>
Sun 27 Nov 2011 05:11:08 PM UTC, comment #2:

OK, seems I missed some calls. I'll removed them for next release. Thanks for reporting.

Jean Bréfort <jean_brefort>
Project AdministratorIn charge of this item.
Sun 27 Nov 2011 04:16:28 PM UTC, comment #1:

the dep on libgcu could be found at:
http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20111127103247.fwang.valstar.17855/log/gnome-chemistry-utils-0.13.5-1.mga2/build.0.20111127103302.log

You will see:
.libs/application.o: In function `gcu::Application::RemoveDocument(gcu::Document*)':
/home/iurt/rpm/BUILD/gnome-chemistry-utils-0.13.5/libs/gcu/application.cc:208: undefined reference to `gtk_main_level'

So, gtk is still required for libgcu.

Funda Wang <fundawang>
Sun 27 Nov 2011 04:14:52 PM UTC, original submission:

I'm building gchemutils 0.13.5 with Mageia Cauldron. Due to old linking libs in multiple Makefile.am files, it builds failed when specifying LDFLAGS="-Wl,--no-undefined".

I've put the required patches here:
http://svnweb.mageia.org/packages/cauldron/gnome-chemistry-utils/current/SOURCES/

I know libgcu and libgcugtk is being splitted, but it seems that it has not been split finally, because libgcu still has dep on gdk. Since there is no such detection on gdk in configure.ac, you may want to add this detection later.

Always try building with LDFLAGS="-Wl,--no-undefined", especially with shared libs.

Funda Wang <fundawang>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by fundawang (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 28 Nov 2011 06:30:38 AM UTCjean_brefortStatusNone=>Done
      Assigned toNone=>jean_brefort
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup