patchmldonkey, a multi-networks file-sharing client - Patches: patch #7756, BT: Add support for magnet links

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7756: BT: Add support for magnet links

Submitted by:  ygrek <ygrek>
Submitted on:  Thu 05 Apr 2012 04:54:57 PM UTC  
Votes:  210  
 
Category:  Improved interfaces Priority:  5 - Normal
Status:  Done Assigned to:  Joakim Verona <jave>
Open/Closed:  Closed

( Jump to the original submission)

Fri 27 Jul 2012 05:47:23 PM UTC, comment #18: 

committed btmagnet3.diff 2012/07/27

spiralvoice <spiralvoice>
Project Administrator
Thu 26 Jul 2012 12:02:24 PM UTC, comment #17: 

patch works fine here, can download via magnet links in webui

ygrek <ygrek>
Project Member
Sat 21 Jul 2012 05:18:28 PM UTC, comment #16: 

spiralvoice, parsing trackers from url is useful, but we need to ensure that we are actually talking to trackers for magnet torrents.

jave, debug output was not removed but guarded with verbose_msg_clients so nothing is lost

ygrek <ygrek>
Project Member
Sat 21 Jul 2012 05:16:44 PM UTC, comment #15: 

Here is an updated cumulative patch.
Changes:
- accept both base16 (hex) and base32 for btih
- cleanup spaces
- remove startbthash

(file #26241)

ygrek <ygrek>
Project Member
Fri 06 Jul 2012 07:46:35 AM UTC, comment #14: 

Tested with mldonkey 3.1.2 and both patches applied. Working fine, using sancho-gui for windows. Can click links on magnet links, which will be added to mldonkey core without any problems.

Dennis <cataclysm>
Tue 03 Jul 2012 01:26:29 PM UTC, comment #13: 

Any plan/date for publishing a mldonkey release with magnet support? :-)

Jesús Cea <jcea>
Tue 03 Jul 2012 10:30:56 AM UTC, comment #12: 

Thanks for working on this Spiralvoice!

The patch looks good IMHO! I will test it.

The only minor nitpick is that some of the debug output was actually comments on the workings of the code, so when you remove them, you also remove the comments. I'll see if I can merge your patch but keep the comments, as proper comments rather than debug output.

Joakim Verona <jave>
Project MemberIn charge of this item.
Sun 01 Jul 2012 08:14:17 AM UTC, comment #11: 

updated additional patch
- silence debugging output
- parse tracker URLs embedded in magnet links (are they of any use?)

(file #26130)

spiralvoice <spiralvoice>
Project Administrator
Sat 30 Jun 2012 09:32:52 PM UTC, comment #10: 

please try this additional patch
- moves temporary torrent (during DHT search) to $MLDONKEY_TEMP and removes it when download of real .torrent finished
- remove startbtmagnet command
- add dllink support for magnet:?xt=urn:btih style URLs

Is command "startbthash" still needed?

(file #26127)

spiralvoice <spiralvoice>
Project Administrator
Wed 09 May 2012 05:35:48 AM UTC, comment #9: 

This seems to work splendidly here. It would be nice if the temporary /tmp/BT-*.torrent could be cleaned up -- probably after "load_torrent_file newtorrentfile owner group"? (A copy of it will exist in ./torrents/downloads

Dennis Nezic <dennisne>
Mon 23 Apr 2012 08:43:35 AM UTC, comment #8: 

Any status on the progress?

raffe <raffe>
Thu 05 Apr 2012 06:25:03 PM UTC, comment #7: 

the most important missing feature is that you need to use a special "startbtmagnet" command. I didnt have time to figure out how to call the magnet parser at the right place in the "dllink" call chain.

also, i placed the downloaded torrent file lazily in "/tmp" rather than i the proper temp dir.

Joakim Verona <jave>
Project MemberIn charge of this item.
Thu 05 Apr 2012 06:20:54 PM UTC, comment #6: 

The patch works well for me, but contains some ugly parts and lacks some features.

Some users expressed difficulty in compiling, so i based the "btmagnet" branch on ygreks "next" branch, and then the user reported success.

So, with those caveats, I suppose the patch can go into cvs.

(btw Im out of time to do any further cleanups to this code now for a while)

Joakim Verona <jave>
Project MemberIn charge of this item.
Thu 05 Apr 2012 04:54:57 PM UTC, comment #5: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client task tracker to your tracker.

The original report is still available at task #11755

Following are the information included in the original report:

[field #0]                  Item ID: 11755
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #6]                    Votes: 290
[field #9]                 Category: Bittorrent-Plugin
[field #10]             Submitted by: ygrek
[field #11]              Assigned to: None
[field #12]             Submitted on: Di 24 Jan 2012 09:21:50 CET
[field #13]                  Summary: BT: Add support for magnet links
[field #14]      Original Submission: TPB is switching to magnet torrent links exclusively, other services will follow.

http://mldonkey.sourceforge.net/phpBB2/viewtopic.php?t=5660 />[field #16]               Item Group: None
[field #17]                   Status: In Progress
[field #18]        Component Version: None
[field #19]         Operating System: None
[field #20]          Reproducibility: None
[field #21]               Size (loc): None
[field #22]            Fixed Release: None
[field #23]          Planned Release: None
[field #24]                   Effort: 0.00
[field #28]                 Priority: 7 - High
[field #29]          Should Start On: Di 24 Jan 2012 01:00:00 CET
[field #30]    Should be Finished on: Di 24 Jan 2012 01:00:00 CET
[field #31]         Percent Complete: 0%
[field #33]                  Release: None
[field #58]     Custom Select Box #1: None
[field #59]     Custom Select Box #2: None
[field #60]     Custom Select Box #3: None
[field #61]     Custom Select Box #4: None
[field #62]     Custom Select Box #5: None
[field #63]     Custom Select Box #6: None
[field #64]     Custom Select Box #7: None
[field #65]     Custom Select Box #8: None
[field #66]     Custom Select Box #9: None
[field #67]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Project Administrator
Thu 05 Apr 2012 04:54:27 PM UTC, comment #4: 

Based on git d2de0bfda4 I extracted the attached patch, which can be used for current CVS, only compile-tested here.
What about committing it to CVS right now?
3.1.1 is released so tests with CVS HEAD can be done utilizing your patch.

(file #25592)

spiralvoice <spiralvoice>
Project Administrator
Thu 22 Mar 2012 11:37:43 PM UTC, comment #3: 

For some reason the BEP9 branch contained some unrelated comits. I made a new branch:

https://github.com/ygrek/mldonkey/tree/btmagnet

Joakim Verona <jave>
Project MemberIn charge of this item.
Wed 21 Mar 2012 08:23:11 AM UTC, comment #2: 

theres a new command "startbtmagnet" now, it has so far managed to download a couple of magnet links. Not to bad!

Joakim Verona <jave>
Project MemberIn charge of this item.
Sun 18 Mar 2012 10:33:42 PM UTC, comment #1: 

there is a WIP patch at:
https://github.com/ygrek/mldonkey/tree/BEP9

it actually managed to download a couple of files already.

use "startbthash" and supply the hash in hex. the hash is the btih part of the magnet link.

Joakim Verona <jave>
Project MemberIn charge of this item.
Thu 05 Apr 2012 04:54:57 PM UTC, original submission:  

TPB is switching to magnet torrent links exclusively, other services will follow.

http://mldonkey.sourceforge.net/phpBB2/viewtopic.php?t=5660

ygrek <ygrek>
Project Member

 

Attached Files
file #26241:  btmagnet3.diff added by ygrek (23KiB - application/octet-stream)
file #26130:  7756_2.patch added by spiralvoice (19KiB - text/x-patch)
file #25592:  btmagnet.diff added by spiralvoice (25KiB - application/x-troff-man)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by cataclysm (Posted a comment)
  • -email is unavailable- added by cataclysm (Voted in favor of this item)
  • -email is unavailable- added by jcea (Posted a comment)
  • -email is unavailable- added by dennisne (Posted a comment)
  • -email is unavailable- added by dennisne (Voted in favor of this item)
  • -email is unavailable- added by dennisne
  • -email is unavailable- added by raffe (Posted a comment)
  • -email is unavailable- added by spiralvoice (Updated the item)
  • -email is unavailable- added by raffe (Voted in favor of this item)
  • -email is unavailable- added by sacrediou (Voted in favor of this item)
  • -email is unavailable- added by jave (Posted a comment)
  • -email is unavailable- added by jcea
  • -email is unavailable- added by ygrek (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 210 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 17 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-07-27 spiralvoice StatusReady For Test => Done
        Open/ClosedOpen => Closed
    2012-07-21 ygrek Attached File- => Added btmagnet3.diff, #26241
    2012-07-06 cataclysm Carbon-Copy- => Added cataclysm
    2012-07-01 spiralvoice Attached File- => Added 7756_2.patch, #26130
    2012-07-01 spiralvoice Attached File#26128 => Removed
    2012-06-30 spiralvoice Attached File- => Added 7756_2.patch, #26128
    2012-06-30 spiralvoice Attached File#26127 => Removed
    2012-06-30 spiralvoice Attached File- => Added btmagnet2.diff, #26127
        StatusIn Progress => Ready For Test
    2012-05-07 dennisne Carbon-Copy- => Added dennisne
    2012-05-07 dennisne Carbon-Copy- => Added -email is unavailable-
    2012-04-05 spiralvoice Assigned toNone => jave
    2012-04-05 spiralvoice CategoryNone => Improved interfaces
        Priority7 - High => 5 - Normal
        StatusNone => In Progress
    2012-04-05 spiralvoice Reassign itemmldonkey, a multi-networks file-sharing client, task #11755 => mldonkey, a multi-networks file-sharing client, patch #7756

    Back to the top


    Powered by Savane 3.7