patchWeeChat - Patches: patch #7974, Provide uniform infolists for...

 
 

patch #7974: Provide uniform infolists for signal callbacks and infolist hook

Submitted by:  Andrew Potter <talisein>
Submitted on:  Sun 17 Mar 2013 09:10:28 PM UTC  
 
Category:  xfer plugin Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  Sebastien Helleu <flashcode> Open/Closed:  Closed
IRC nick:  talisein

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 06 Jan 2014 03:01:47 PM UTC, comment #2:

Committed.

And I added similar thing for "protocol" vs "protocol_string", for consistency between infolists.

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Tue 02 Apr 2013 09:25:37 PM UTC, comment #1:

The previous patch changes a couple fields type, such as type becoming type_string. I audited everything in weechat that uses xfer signals (its just irc-server.c). I also grepped all the scripts and none of them use xfer signals.

The attached patch adds the only change needed to keep everything working.

(file #27750)

Andrew Potter <talisein>
Sun 17 Mar 2013 09:10:28 PM UTC, original submission:

xfer callbacks provide a very limited subset of infolist information compared to what is returned from weechat_infolist_get("xfer", ...).

In my case I was interested in the local_filename and status fields on the xfer_ended signal.

The attached patch gives signal callbacks the same infolist that infolist_get("xfer", ...) would return, except only for the single xfer that produced the signal.

Andrew Potter <talisein>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #27622:  0001-xfer-Provide-uniform-infolists-for-signal-callbacks-.patch added by talisein (2KiB - text/x-patch - Correctly rebased to today's git)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by flashcode (Posted a comment)
  • -email is unavailable- added by talisein (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-02-09 flashcode Open/ClosedOpen => Closed
    2014-01-06 flashcode StatusNone => Done
        Assigned toNone => flashcode
    2013-04-02 talisein Attached File- => Added 0001-xfer-Provide-uniform-infolists-for-signal-callbacks-.patch, #27750
    2013-03-17 talisein Attached File- => Added 0001-xfer-Provide-uniform-infolists-for-signal-callbacks-.patch, #27622
    2013-03-17 talisein Attached File- => Added 0001-xfer-Provide-uniform-infolists-for-signal-callbacks-.patch, #27621

    Back to the top


    Powered by Savane 3.3