patchmldonkey, a multi-networks file-sharing client - Patches: patch #8415, Revert "gettext: reduce...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8415: Revert "gettext: reduce complexity, drop unused code" to fix GTK2 gui's compilation

Submitter:  David Coppa <dcoppa_openbsd>
Submitted:  Sat 22 Mar 2014 11:03:02 AM UTC
   
 
Category:  Bug fixes Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Sat 22 Mar 2014 11:11:18 AM UTC, comment #4: 

committed 2014/03/22

spiralvoice <spiralvoice>
Group administrator
Sat 22 Mar 2014 11:03:02 AM UTC, comment #3: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client bugs tracker to your tracker.

The original report is still available at bugs #41853

Following are the information included in the original report:

[field #0]                  Item ID: 41853
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #8]                         : Unknown bugs Field Display Type
[field #9]                 Category: GUI GTK2
[field #10]             Submitted by: dcoppa_openbsd
[field #11]              Assigned to: None
[field #12]             Submitted on: Do 13 Mär 2014 14:20:30 CET
[field #13]                  Summary: Revert "gettext: reduce complexity, drop unused code" to fix  GTK2 gui's compilation
[field #14]      Original Submission:
Hi!

The commit "gettext: reduce complexity, drop unused code" (d7e9f64f7c1fcd86e7a2b56f0951245386811942) broke GTK2 gui's compilation:

---8<---

ocamlopt.opt -inline 10    -I src/utils/extlib  -I src/utils/cdk  -I src/utils/bitstring  -I src/utils/lib  -I src/utils/ocamlrss  -I src/utils/xml-light  -I
 src/utils/net  -I tools  -I src/daemon/common  -I src/daemon/driver  -I src/utils/mp3tagui  -I src/config/unix  -I src/gtk2/gui  -I src/gtk2/gui/x11  -I src
/gtk2/gui/win32  -I icons/rsvg  -I +lablgtk2  -I src/networks/direct_connect  -I src/networks/fasttrack  -I src/networks/fileTP  -I src/networks/bittorrent
-I src/networks/donkey -I +camlp4 -c src/gtk2/gui/guiMessages.ml

File "src/gtk2/gui/guiMessages.ml", line 197, characters 38-46:
Error: Unbound module T
Makefile:5461: recipe for target 'src/gtk2/gui/guiMessages.cmx' failed
make: * [src/gtk2/gui/guiMessages.cmx] Error 2

---8<---

I think a (at least partial) revert is needed.

[field #16]               Item Group: Compilation problem
[field #17]                   Status: None
[field #18]        Component Version: None
[field #19]         Operating System: None
[field #20]          Reproducibility: None
[field #21]               Size (loc): None
[field #22]            Fixed Release: None
[field #23]          Planned Release: None
[field #24]                   Effort: 0.00
[field #28]                 Priority: 5 - Normal
[field #31]         Percent Complete: 0%
[field #33]                  Release: None
[field #34]                  Release: 3.1.4
[field #58]          Binaries Origin: CVS / Self compiled
[field #59]                 CPU type: None
[field #60]                      CPU: None
[field #61]     Custom Select Box #4: None
[field #62]     Custom Select Box #5: None
[field #63]     Custom Select Box #6: None
[field #64]     Custom Select Box #7: None
[field #65]     Custom Select Box #8: None
[field #66]     Custom Select Box #9: None
[field #67]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Group administrator
Thu 13 Mar 2014 03:48:19 PM UTC, comment #2: 


Your fix that reverts commit 6a094b4 works fine for me.

Thanks a lot!
David

David Coppa <dcoppa_openbsd>
Thu 13 Mar 2014 03:22:42 PM UTC, comment #1: 
ygrek <ygrek>
Group Member
Sat 22 Mar 2014 11:03:02 AM UTC, original submission:  


Hi!

The commit "gettext: reduce complexity, drop unused code" (d7e9f64f7c1fcd86e7a2b56f0951245386811942) broke GTK2 gui's compilation:

---8<---

ocamlopt.opt -inline 10    -I src/utils/extlib  -I src/utils/cdk  -I src/utils/bitstring  -I src/utils/lib  -I src/utils/ocamlrss  -I src/utils/xml-light  -I
 src/utils/net  -I tools  -I src/daemon/common  -I src/daemon/driver  -I src/utils/mp3tagui  -I src/config/unix  -I src/gtk2/gui  -I src/gtk2/gui/x11  -I src
/gtk2/gui/win32  -I icons/rsvg  -I +lablgtk2  -I src/networks/direct_connect  -I src/networks/fasttrack  -I src/networks/fileTP  -I src/networks/bittorrent
-I src/networks/donkey -I +camlp4 -c src/gtk2/gui/guiMessages.ml

File "src/gtk2/gui/guiMessages.ml", line 197, characters 38-46:
Error: Unbound module T
Makefile:5461: recipe for target 'src/gtk2/gui/guiMessages.cmx' failed
make: * [src/gtk2/gui/guiMessages.cmx] Error 2

---8<---

I think a (at least partial) revert is needed.

David Coppa <dcoppa_openbsd>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #31001:  8328_revert.patch added by spiralvoice (8KiB - text/x-patch)
file #30878:  gtk2_gui_build_error.log added by dcoppa_openbsd (746B - application/octet-stream - Log of the gtk2 gui's build error)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by spiralvoice (Updated the item)
  • -email is unavailable- added by ygrek (Posted a comment)
  • -email is unavailable- added by dcoppa_openbsd (Submitted the item)
  • -email is unavailable- added by dcoppa_openbsd (my gmail address)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-03-22 spiralvoice CategoryNone Bug fixes
        StatusNone Done
        Open/ClosedOpen Closed
    2014-03-22 spiralvoice Reassign itemmldonkey, a multi-networks file-sharing client, bug #41853 mldonkey, a multi-networks file-sharing client, patch #8415

    Back to the top

    Powered by Savane 3.13-bb6a.
    Corresponding source code