patchBos Wars - Patches: patch #8598, Script make.py uses hardcoded paths

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8598: Script make.py uses hardcoded paths

Submitter:  Régis Cuisset <rcui>
Submitted:  Mon 26 Jan 2015 09:51:07 PM UTC
   
 
Open/Closed:  Closed Status:  Wont Do
Assigned to:  None

Thu 15 Jun 2023 01:13:17 PM UTC, comment #1: 

Little nitpick: the paths are not not hardcoded, the path seperator is.

As discussed on IRC (https://colabti.org/irclogger/irclogger_log/boswars?date=2015-01-27#l26), os.path.join() makes the code mor cumbersome for no practical benefit in our case. (Besides, I think Windows can work with "/" too)

François Beerten <feb>
Group administrator
Mon 26 Jan 2015 09:51:07 PM UTC, original submission:  

Hello,

This is a patch that makes the make.py script use python's standard library functions of module os.path instead of having hardcoded directory separators '/'.

This doesn't change the script behavior (I have recompiled the game successfully with this patch).

I have other ideas about enhancements of this kind, so let me know if these are welcome.

Régis Cuisset <rcui>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #32915:  os_path.diff added by rcui (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by feb (Posted a comment)
  • -email is unavailable- added by rcui (Submitted the item)
  •  

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-06-15 feb Open/ClosedOpen Closed
        StatusNone Wont Do
    2015-01-26 rcui Attached File- Added os_path.diff, #32915

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code