Bos Wars - Patches: patch #8598, Script make.py uses hardcoded paths
You are not allowed to post comments on this tracker with your current authentication level.
patch #8598: Script make.py uses hardcoded paths
Submitter: | Régis Cuisset <rcui> | ||
Submitted: | Mon 26 Jan 2015 09:51:07 PM UTC | ||
Open/Closed: | Closed | Status: | Wont Do |
Assigned to: | None |
Thu 15 Jun 2023 01:13:17 PM UTC, comment #1: |
François Beerten <feb> |
Mon 26 Jan 2015 09:51:07 PM UTC, original submission:
Hello,
|
Régis Cuisset <rcui> |
Attached Files
Depends on the following items: None found
Items that depend on this one: None found
Carbon-Copy List
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2023-06-15 | feb | Open/Closed | Open | Closed | |
Status | None | Wont Do | |||
2015-01-26 | rcui | Attached File | - | Added os_path.diff, #32915 |
Powered by Savane 3.13-f8d8.
Corresponding source code
Little nitpick: the paths are not not hardcoded, the path seperator is.
As discussed on IRC (https://colabti.org/irclogger/irclogger_log/boswars?date=2015-01-27#l26), os.path.join() makes the code mor cumbersome for no practical benefit in our case. (Besides, I think Windows can work with "/" too)