patchmldonkey, a multi-networks file-sharing client - Patches: patch #4479, Callback mechanism for low ID...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4479: Callback mechanism for low ID users does not work.

Submitter:  Dirk Tilger <miriup>
Submitted:  Fri 30 Sep 2005 11:36:54 AM UTC
   
 
Category:  Bug fixes Priority:  3 - Low
Status:  Done Assigned to:  None
Open/Closed:  Closed

Sat 19 Nov 2005 04:22:38 PM UTC, comment #2: 

Applied 2005/11/19

spiralvoice <spiralvoice>
Group administrator
Fri 30 Sep 2005 11:42:45 AM UTC, comment #1: 

Sorry, I actually wanted to point to patch #3717, because this was the one that made it working finally for all parties. The other one I was mentioning was the one that made the High-ID handling sometimes quite inefficient.

Dirk.

Dirk Tilger <miriup>
Fri 30 Sep 2005 11:36:54 AM UTC, original submission:  

This patch is related to patch #3672 and the discussion http://mldonkey.berlios.de/modules.php?name=Forums&file=viewtopic&t=3159

The main problem is that most peers will recognize a client that called back not just by the (Low) ID, but also from the server the client is connected to. When the server IP/port is wrong (or 0.0.0.0:0) most clients will expect the peer to initiate some "give me this chunk" or "tell me what files you have" requests. Since mldonkey does not issue such a thing, because it was just asked to call back, the connection will sit idle for some time and be closed after three tries or so.

At the time with the patch mentioned in the beginning the issue worked, but it got broken again and this patch claims to repair it. I've been using it since release-2-6-1 until release-2-6-3. I forgot to submit my patch, but it proved to work for my low-id configuration.

However, sometimes, especially when I have no files to download I do not receive callbacks at all. It is suggested to apply this patch in a testing mldonkey for a week on a non-low id connection before including it in a stable release, to avoid side effects similar to the thread mentioned above. I can't test high-ID at all.

Dirk.

Dirk Tilger <miriup>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #8130:  diff added by miriup (824B - application/octet-stream - Reactivating submission of server IP and port during client handshake in edonkey)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-11-19 spiralvoice StatusNone Done
    Open/ClosedOpen Closed
2005-09-30 miriup Attached File- Added diff, #5265
    Carbon-Copy- Added miriup

Back to the top

Powered by Savane 3.13-bb6a.
Corresponding source code