mldonkey, a multi-networks file-sharing client - Patches: patch #5336, Fix LowID support for eDonkey...
You are not allowed to post comments on this tracker with your current authentication level.
patch #5336: Fix LowID support for eDonkey network
Submitter: | Krzysztof Nowicki <krissn> | ||
Submitted: | Sun 27 Aug 2006 06:12:21 PM UTC | ||
Category: | Bug fixes | Priority: | 7 - High |
Status: | Done | Assigned to: | None |
Open/Closed: | Closed |
Jump to the original submission
Mon 25 Sep 2006 10:40:59 PM UTC, comment #7: |
spiralvoice <spiralvoice> |
Sun 10 Sep 2006 09:26:13 PM UTC, comment #6: I use this patch and it appears ok.
|
Joakim Verona <jave> |
Tue 29 Aug 2006 10:28:45 AM UTC, comment #5: Missed another spot where the indirect client's IP:port wasn't being set to null. Now this seems to really work as expected. |
Krzysztof Nowicki <krissn> |
Mon 28 Aug 2006 03:55:46 PM UTC, comment #4: I've corrected the patch implemented the same comparison scheme when finding a source for a client (donkeyGlobals:619). This seems to prevent double sources from appearing on the list (two sources with the same id) |
Krzysztof Nowicki <krissn> |
Sun 27 Aug 2006 07:00:19 PM UTC, comment #3: I did, but I must have somehow omitted this one... But why should we check the server IP after all? |
Krzysztof Nowicki <krissn> |
Sun 27 Aug 2006 06:50:48 PM UTC, comment #2: About the first part of your patch, did you read this?
|
spiralvoice <spiralvoice> |
Sun 27 Aug 2006 06:50:18 PM UTC, comment #1: Re-made the patch, because it didn't apply cleanly against version 2.7.7. |
Krzysztof Nowicki <krissn> |
Sun 27 Aug 2006 06:12:21 PM UTC, original submission:
The fact that MLDonkey has a problem with indirect connections is really nothing new. I've been digging into this for some time and I think I found the main reason why this doesn't work. The normal handling of a LowID client is as follows:
|
Krzysztof Nowicki <krissn> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 8 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2006-09-25 | spiralvoice | Status | None | Done | |
Open/Closed | Open | Closed | |||
2006-08-29 | krissn | Attached File | - | Added mldonkey-2.7.7-lowid-4.patch, #10627 | |
2006-08-28 | krissn | Attached File | - | Added mldonkey-2.7.7-lowid-3.patch, #10617 | |
2006-08-27 | spiralvoice | Priority | 5 - Normal | 7 - High | |
2006-08-27 | krissn | Attached File | - | Added mldonkey-2.7.7-lowid-2.patch, #10612 | |
2006-08-27 | spiralvoice | Attached File | - | Added 5336_2.patch, #10611 | |
2006-08-27 | krissn | Attached File | - | Added mldonkey-2.7.7-lowid.patch, #10610 |
Powered by Savane 3.13-caa5.
Corresponding source code
Applied 2006/09/26