patchmldonkey, a multi-networks file-sharing client - Patches: patch #6961, BT: Fix torrent parsing when...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6961: BT: Fix torrent parsing when announce-list is empty

Submitted by:  Hose Bag <user>
Submitted on:  Fri 23 Oct 2009 05:24:28 AM UTC  
 
Category:  None Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Fri 23 Oct 2009 05:29:57 AM UTC, comment #4: 

committed 2009/10/23

spiralvoice <spiralvoice>
Project Administrator
Fri 23 Oct 2009 05:24:28 AM UTC, comment #3: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client bugs tracker to your tracker.

The original report is still available at bugs #27781

Following are the information included in the original report:

[field #0]                  Item ID: 27781
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 4 - Important
[field #4]                  Privacy: Public
[field #6]                    Votes: 40
[field #8]                         : Unknown bugs Field Display Type
[field #9]                 Category: Bittorrent-Plugin
[field #10]             Submitted by: user
[field #11]              Assigned to: None
[field #12]             Submitted on: Do 22 Okt 2009 17:13:00 CEST
[field #13]                  Summary: BT: Fix torrent parsing when announce-list is empty
[field #14]      Original Submission: Some torrent files are discarded by mldonkey with this message in log:
[BT] Error Failure("hd") in scan_new_torrents_directory for file.torrent, moved to torrents/old ...
3.0.0-3 from squeeze is also affected.

I tried to fix this, and it turns out that some internal list is empty
when program tries to get it's first element.
This patch checks list length before using it. Works fine for me.

Sample torrent:
http://www.mininova.org/tor/3070173

[field #16]               Item Group: Program malfunction
[field #17]                   Status: Ready For Test
[field #18]        Component Version: None
[field #19]         Operating System: Linux
[field #20]          Reproducibility: None
[field #21]               Size (loc): None
[field #22]            Fixed Release: None
[field #23]          Planned Release: None
[field #24]                   Effort: 0.00
[field #28]                 Priority: 5 - Normal
[field #31]         Percent Complete: 0%
[field #33]                  Release: 2.9.5
[field #58]          Binaries Origin: Debian package
[field #59]                 CPU type: None
[field #60]                      CPU: None
[field #61]     Custom Select Box #4: None
[field #62]     Custom Select Box #5: None
[field #63]     Custom Select Box #6: None
[field #64]     Custom Select Box #7: None
[field #65]     Custom Select Box #8: None
[field #66]     Custom Select Box #9: None
[field #67]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Project Administrator
Fri 23 Oct 2009 04:45:41 AM UTC, comment #2: 

Your patch works fine, too.

Hose Bag <user>
Thu 22 Oct 2009 08:13:45 PM UTC, comment #1: 

Please try the attached patch instead.

It uses Ocaml exception handling in case
of an error and saves the handling of the
if-then code in your patch.

(file #18929)

spiralvoice <spiralvoice>
Project Administrator
Fri 23 Oct 2009 05:24:28 AM UTC, original submission:  

Some torrent files are discarded by mldonkey with this message in log:
[BT] Error Failure("hd") in scan_new_torrents_directory for file.torrent, moved to torrents/old ...
3.0.0-3 from squeeze is also affected.

I tried to fix this, and it turns out that some internal list is empty
when program tries to get it's first element.
This patch checks list length before using it. Works fine for me.

Sample torrent:
http://www.mininova.org/tor/3070173

Hose Bag <user>

 

Attached Files
file #18929:  bt_announce.diff added by spiralvoice (804B - text/x-diff)
file #18924:  check_next_urls.diff added by user (653B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by spiralvoice (Updated the item)
  • -email is unavailable- added by user
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-10-23 spiralvoice StatusNone => Done
        Open/ClosedOpen => Closed
    2009-10-23 spiralvoice Reassign itemmldonkey, a multi-networks file-sharing client, bug #27781 => mldonkey, a multi-networks file-sharing client, patch #6961

    Back to the top


    Powered by Savane 3.5