lwIP - A Lightweight TCP/IP stack - Patches: patch #6370, Sending to myself
You are not allowed to post comments on this tracker with your current authentication level.
patch #6370: Sending to myself
Submitter: | Luca Ceresoli <lucaceresoli> | ||
Submitted: | Fri 11 Jan 2008 02:04:06 PM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | goldsimon | Open/Closed: | Closed |
Planned Release: | None |
Jump to the original submission
Thu 19 Jun 2008 04:28:37 PM UTC, comment #24: |
Simon Goldschmidt <goldsimon> |
Wed 18 Jun 2008 07:26:37 PM UTC, comment #23: The include change is correct, I messed that up.
|
Simon Goldschmidt <goldsimon> |
Wed 18 Jun 2008 03:31:45 PM UTC, comment #22: Tested and working! (NO_SYS=1)
|
Luca Ceresoli <lucaceresoli> |
Tue 17 Jun 2008 07:42:53 PM UTC, comment #21: I just changed the loopback code a little: Basically, the multithreading environment now behaves much the same like the
|
Simon Goldschmidt <goldsimon> |
Mon 16 Jun 2008 03:26:50 PM UTC, comment #20: What you say is true of course. But now that we know exactly where netif_loop_output() is called (only from ip.c), I think we can safely call ip_input() from netif_poll().
|
Simon Goldschmidt <goldsimon> |
Mon 16 Jun 2008 10:43:55 AM UTC, comment #19:
There are. :-[
|
Luca Ceresoli <lucaceresoli> |
Thu 12 Jun 2008 08:18:01 PM UTC, comment #18:
|
Simon Goldschmidt <goldsimon> |
Tue 08 Apr 2008 04:16:12 PM UTC, comment #17: I'm so sorry I haven't answered yet, but I just couldn't find the time to work on it...
|
Simon Goldschmidt <goldsimon> |
Tue 08 Apr 2008 02:44:32 PM UTC, comment #16: I'll recap what this patch is, so hopefully we may reach a final merge/reject decision.
|
Luca Ceresoli <lucaceresoli> |
Tue 01 Apr 2008 06:58:33 PM UTC, comment #15: Sorry guys, I really seem to have forgotten most of this (well, it's been a while :)...
|
Simon Goldschmidt <goldsimon> |
Mon 31 Mar 2008 01:13:20 PM UTC, comment #14: I haven't gone back carefully through the old comments to compare against what's been done, but I think it looks reasonable. Simon? |
Jonathan Larmour <jifl> |
Mon 31 Mar 2008 08:31:31 AM UTC, comment #13: Now that 1.3.0 is out, time to recap with this patch.
|
Luca Ceresoli <lucaceresoli> |
Fri 18 Jan 2008 10:23:00 AM UTC, comment #12: Here is my new patch, I just renamed some defines and variables as discussed here.
I agree with all of the three, and also with comment #10: better adding them after the current patch is merged.
|
Luca Ceresoli <lucaceresoli> |
Thu 17 Jan 2008 07:40:27 PM UTC, comment #11: Right. And it's a pity this can't go into 1.3.0, but on the other hand, it's good to know it is finally coming! |
Simon Goldschmidt <goldsimon> |
Thu 17 Jan 2008 05:46:39 PM UTC, comment #10: It looks like trunk has frozen for 1.3.0 so the discussion about forward compatibility becomes irrelevant!
|
Jonathan Larmour <jifl> |
Wed 16 Jan 2008 06:56:27 PM UTC, comment #9:
|
Simon Goldschmidt <goldsimon> |
Tue 15 Jan 2008 07:35:30 PM UTC, comment #8: Luca,
|
Simon Goldschmidt <goldsimon> |
Tue 15 Jan 2008 10:16:11 AM UTC, comment #7:
I'm not proud of them, my muse was on vacation that day.
I see no advantage in that apart from backward compatibility (which is a no-issue, according to Jonathan).
|
Luca Ceresoli <lucaceresoli> |
Mon 14 Jan 2008 06:54:59 PM UTC, comment #6: I'm think the function 'netif_poll' could be misleading, since other netifs can be in polling mode also, which means they simply don't use interrupts...
|
Simon Goldschmidt <goldsimon> |
Mon 14 Jan 2008 04:27:03 PM UTC, comment #5: This seems much better, thanks. I'm a bit unconvinced of some of the naming ("ENABLE_SELF" etc.) and think just referring to it as loopback packets may be clearer, but that's a detail to deal with later.
|
Jonathan Larmour <jifl> |
Fri 11 Jan 2008 06:21:03 PM UTC, comment #4:
Not necessarily, but the first patch led to dropped packets at the UDP level when the pcb is bound to a local address, and maybe other problems also involving TCP. Going on with that patch would have led to patching udp.c and perhaps tcp.c and icmp.c. Sounds bad for IP-related things. This was the meaning of "invasive", not the quantity of code.
|
Luca Ceresoli <lucaceresoli> |
Fri 11 Jan 2008 04:44:08 PM UTC, comment #3: I too am sceptical that this is a good general solution. It's definitely not something for 1.3.0.
|
Kieran Mansley <kieranm> |
Fri 11 Jan 2008 03:02:08 PM UTC, comment #2: After taking the approach of changing ip_route() there were some issues, but you said these would be too invasive to fix. But I wouldn't have thought it would be that invasive; or at least less so than the patch here. It seems not very good to have so much new code here, especially since it's similar to loopif.
|
Jonathan Larmour <jifl> |
Fri 11 Jan 2008 02:20:21 PM UTC, comment #1: First: I'd like to see this general feature to be included in the stack.
|
Simon Goldschmidt <goldsimon> |
Fri 11 Jan 2008 02:04:06 PM UTC, original submission:
Support sending packets with a destination IP address equal to the netif IP address, looping them back up the stack (off by default).
|
Luca Ceresoli <lucaceresoli> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 11 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2008-06-19 | goldsimon | Status | Ready For Test | Done | |
Open/Closed | Open | Closed | |||
2008-06-17 | goldsimon | Status | In Progress | Ready For Test | |
2008-06-16 | goldsimon | Status | Ready For Test | In Progress | |
2008-06-16 | lucaceresoli | Attached File | - | Added netif_input.patch, #15851 | |
2008-06-12 | goldsimon | Status | None | Ready For Test | |
Assigned to | None | goldsimon | |||
2008-01-18 | lucaceresoli | Attached File | - | Added self-netif3.patch, #14825 | |
2008-01-14 | jifl | Attached File | - | Added netif.poll.future.compat.patch, #14795 | |
2008-01-11 | lucaceresoli | Attached File | - | Added self-netif2.patch, #14784 | |
2008-01-11 | lucaceresoli | Attached File | - | Added self-netif.patch, #14783 |
Powered by Savane 3.13-f8d8.
Corresponding source code
I fixed the include and removed loop_cnt_max (using the define to test for max), so this should be done now.