lwIP - A Lightweight TCP/IP stack - Patches: patch #6480, slipif.c has no #ifdef
You are not allowed to post comments on this tracker with your current authentication level.
patch #6480: slipif.c has no #ifdef
Submitter: | Iordan Neshev <iordan_neshev> | ||
Submitted: | Wed 26 Mar 2008 02:46:35 PM UTC | ||
Category: | None | Priority: | 3 - Low |
Status: | Done | Privacy: | Public |
Assigned to: | fbernon | Open/Closed: | Closed |
Planned Release: | None |
Jump to the original submission
Tue 17 Jun 2008 08:14:37 PM UTC, comment #9: |
Simon Goldschmidt <goldsimon> |
Mon 05 May 2008 05:05:14 AM UTC, comment #8: Hmm, I must say I don't have a strong opinion on this any more... Go ahead and change it if you like. |
Simon Goldschmidt <goldsimon> |
Sun 04 May 2008 07:49:39 PM UTC, comment #7: Simon, are you always against that ? Or do you prefer to close it as invalid ?
|
Frédéric Bernon <fbernon> |
Sun 30 Mar 2008 07:54:28 AM UTC, comment #6:
yes, but just since december, and it was in opt.h since several months...
|
Frédéric Bernon <fbernon> |
Thu 27 Mar 2008 07:13:51 PM UTC, comment #5: LWIP_HAVE_LOOPIF is used by dns.c.
|
Jonathan Larmour <jifl> |
Thu 27 Mar 2008 06:38:50 PM UTC, comment #4: About comment #2, in this case, why have LWIP_HAVE_LOOPIF and PPP_SUPPORT in opt.h? Since slipif is one of the default netif provided by lwIP, it should be logical to do the same for these others modules.
|
Frédéric Bernon <fbernon> |
Thu 27 Mar 2008 06:34:36 PM UTC, comment #3: You are right. opt.h is large enough.
|
Iordan Neshev <iordan_neshev> |
Thu 27 Mar 2008 06:17:30 PM UTC, comment #2: I'd strongly vote against this: just compile slipif.c only if you want it to go into the build. Including the LWIP_HAVE_SLIPIF=1 in opt.h would make the file bigger without helping much: not many people will want this enabled... |
Simon Goldschmidt <goldsimon> |
Wed 26 Mar 2008 06:33:52 PM UTC, comment #1: No really necessary, but in the spirit of the others netifs.
|
Frédéric Bernon <fbernon> |
Wed 26 Mar 2008 02:46:35 PM UTC, original submission:
Hello
|
Iordan Neshev <iordan_neshev> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2008-06-17 | goldsimon | Open/Closed | Open | Closed | |
2008-06-17 | goldsimon | Status | None | Done | |
2008-03-26 | fbernon | Priority | 5 - Normal | 3 - Low | |
Assigned to | None | fbernon |
Powered by Savane 3.13-d3ae.
Corresponding source code
I've just checked this in now.