lwIP - A Lightweight TCP/IP stack - Patches: patch #6765, Supporting new line characters in...
You are not allowed to post comments on this tracker with your current authentication level.
patch #6765: Supporting new line characters in inet_aton()
Submitter: | Tai-hwa Liang <atliang> | ||
Submitted: | Wed 04 Mar 2009 03:39:51 AM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | goldsimon | Open/Closed: | Closed |
Planned Release: | 1.3.1 |
Jump to the original submission
Fri 24 Apr 2009 12:15:05 PM UTC, comment #12: |
Frédéric Bernon <fbernon> |
Fri 24 Apr 2009 10:42:54 AM UTC, comment #11: Oups, really sorry, I miss that in post #6 :((
|
Frédéric Bernon <fbernon> |
Fri 24 Apr 2009 10:39:58 AM UTC, comment #10:
|
Simon Goldschmidt <goldsimon> |
Fri 24 Apr 2009 08:55:13 AM UTC, comment #9: Simon, are you agree with my last comments ? Can I check in the change I propose in comment #7 |
Frédéric Bernon <fbernon> |
Thu 23 Apr 2009 07:37:19 PM UTC, comment #8: With the change I propose, this code :
|
Frédéric Bernon <fbernon> |
Thu 23 Apr 2009 07:22:59 PM UTC, comment #7: I test again, but inet_addr("3com.com") return 0x3 (and in my point of view, we should got 0x00). It's due to the fact we leave the loop when we reach the first 'c', and in your change, isprint('c') is true, so, don't go to the next line (return 0).
|
Frédéric Bernon <fbernon> |
Thu 23 Apr 2009 04:33:45 PM UTC, comment #6: Sorry, seems like I messed that up. I converted
|
Simon Goldschmidt <goldsimon> |
Thu 23 Apr 2009 03:46:19 PM UTC, comment #5: yes, I can ! :) |
Frédéric Bernon <fbernon> |
Thu 23 Apr 2009 03:45:14 PM UTC, comment #4: Could you try reverting this change and see if it fixes the problem you're seeing Frédéric? |
Kieran Mansley <kieranm> |
Thu 23 Apr 2009 03:41:26 PM UTC, comment #3: I'm not sure if there is a real relation, but now, the win32 port resolve inet_aton("3com.com") as 0.0.0.3 (I'm pretty sure that it was working - returns 0 - there is a long time ago) |
Frédéric Bernon <fbernon> |
Wed 15 Apr 2009 07:06:51 PM UTC, comment #2: I guess the actual bug here is fixed like this:
|
Simon Goldschmidt <goldsimon> |
Thu 09 Apr 2009 03:25:30 PM UTC, comment #1: Anyone got any objections to this? The proposed patch does allow all characters with ascii code < 0x20 to be accepted, not just \n and \r. It's not clear to me what the original line was trying to achieve:
|
Kieran Mansley <kieranm> |
Wed 04 Mar 2009 03:39:51 AM UTC, original submission:
Following calls return the same on *BSD, Linux and Solaris:
|
Tai-hwa Liang <atliang> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 7 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2009-04-24 | fbernon | Open/Closed | Open | Closed | |
2009-04-23 | fbernon | Open/Closed | Closed | Open | |
2009-04-15 | goldsimon | Status | None | Done | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed | |||
2009-04-03 | kieranm | Planned Release | None | 1.3.1 | |
2009-03-04 | atliang | Attached File | - | Added inet.c.patch, #17577 |
Powered by Savane 3.13-758e.
Corresponding source code
Ok, check in