patchlwIP - A Lightweight TCP/IP stack - Patches: patch #7840, Segfault in dhcp_parse_reply if no...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7840: Segfault in dhcp_parse_reply if no end marker in dhcp packet

Submitter:  Henrik Persson <hnrkp>
Submitted:  Thu 30 Aug 2012 12:03:51 PM UTC
   
 
Category:  None Priority:  7 - High
Status:  Done Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Closed
Planned Release:  None

Thu 27 Sep 2012 05:48:48 PM UTC, comment #4: 

Can you convert the comment from // to /* */ ?

I get:


../../../../../lwip/src/core/dhcp.c:1485:9: error: C++ style comments are not allowed in ISO C90
../../../../../lwip/src/core/dhcp.c:1485:9: error: (this will be reported only once per input file)
gcc -g -Wall -Dunix -DIPv4 -DLWIP_DEBUG -pedantic -Werror -Wparentheses -Wsequence-point -Wswitch-default -Wextra -Wundef -Wshadow -Wpointer-arith -Wbad-function-cast -Wc++-compat -Wwrite-strings -Wold-style-definition -Wmissing-prototypes -Wredundant-decls -Wnested-externs -I. -I../../../../apps/httpserver_raw -I../../../../apps/shell -I../../../../apps/tcpecho -I../../../../apps/udpecho -I../../../../../lwip/src/include -I../../../../ports/unix/include -I../../../../../lwip/src/include/ipv4 -I../../../../../lwip/src/include/ipv6 -I../../../../../lwip/src -c
gcc: no input files
make: * [def.o] Error 1

Erik Ekman <yarrick>
Group Member
Wed 26 Sep 2012 07:23:06 PM UTC, comment #3: 

Finally fixed, thanks for reporting.

Simon Goldschmidt <goldsimon>
Group administrator
Thu 13 Sep 2012 04:28:56 PM UTC, comment #2: 

Yes, this is the proper way. The lack of response is not related to the severity, it's rather the lack of developer's time, I guess. Since its not hard to fix, I'd target this for the next release.

Simon Goldschmidt <goldsimon>
Group administrator
Thu 13 Sep 2012 01:06:53 PM UTC, comment #1: 

Hi,

Is this the proper way to submit fixes for lwip or should a bug report be filed? Given the severity of this issue and the total lack of response to it I have to ask..

Kind regards,
Henrik

Henrik Persson <hnrkp>
Thu 30 Aug 2012 12:03:51 PM UTC, original submission:  

If no endmarker is present in a dhcp reply a null pointer is potentially
dereferenced.

Add fix and test case as proof of concept.

This also exists in 1.4 and should be patched before release of 1.4.1. Confirmed to exist in the field with certain cisco routers.

Henrik Persson <hnrkp>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by yarrick (Posted a comment)
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by hnrkp (Submitted the item)
  • -email is unavailable- added by hnrkp
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-09-26 goldsimon StatusNone Done
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2012-08-30 hnrkp Attached File- Added 0001-Segfault-in-dhcp_parse_reply-if-no-end-marker.patch, #26450
        Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code