lwIP - A Lightweight TCP/IP stack - Patches: patch #9430, altcp API multiples fixes
You are not allowed to post comments on this tracker with your current authentication level.
patch #9430: altcp API multiples fixes
Submitter: | David GIRAULT <dgirault> | ||
Submitted: | Mon 07 Aug 2017 02:18:41 PM UTC | ||
Category: | apps | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | goldsimon | Open/Closed: | Closed |
Planned Release: | 2.1.0 |
Jump to the original submission
Tue 16 Jan 2018 08:49:42 PM UTC, comment #8: |
Simon Goldschmidt <goldsimon> |
Tue 16 Jan 2018 08:28:40 AM UTC, comment #7: Currently rebasing my own master to yours, I understood that you revert the altcp_free(inner_conn), because of double free, but I don't see where the inner_conn is freed... Could you give me some tips?
|
David GIRAULT <dgirault> |
Wed 15 Nov 2017 09:00:04 PM UTC, comment #6: After finally finding the time to continue on this: my apologies, the mbedtls part was nearly correct.
|
Simon Goldschmidt <goldsimon> |
Wed 20 Sep 2017 07:19:59 PM UTC, comment #5: OK, I've pushed the fix to altcp_tcp.c (slightly modified).
|
Simon Goldschmidt <goldsimon> |
Mon 28 Aug 2017 08:01:36 PM UTC, comment #4: Thanks. I'll try to review this after fixing bug #51687 |
Simon Goldschmidt <goldsimon> |
Wed 09 Aug 2017 05:31:46 PM UTC, comment #3: I'm not really conviced too for the altcp_tcp_close() changes. But, this fix is the only way I got altcp_pcb leaks fixed.
|
David GIRAULT <dgirault> |
Tue 08 Aug 2017 10:56:26 AM UTC, comment #2: I've pushed your patches with 2 changes:
|
Simon Goldschmidt <goldsimon> |
Tue 08 Aug 2017 08:56:11 AM UTC, comment #1: Thanks for the patches! The work on altcp is not finished yet, so any improvement is welcome!
|
Simon Goldschmidt <goldsimon> |
Mon 07 Aug 2017 02:18:41 PM UTC, original submission:
In our project, we use the altcp layer to support both MQTT and HTTP/HTTPS.
|
David GIRAULT <dgirault> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 12 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-11-15 | goldsimon | Status | In Progress | Done | |
Open/Closed | Open | Closed | |||
Planned Release | None | 2.1.0 | |||
2017-08-09 | dgirault | Attached File | - | Added 0001-altcp_tcp-free-altcp_pcb-struct-in-altcp_tcp_close.patch, #41464 | |
Attached File | - | Added 0002-altcp_mbedtls-close-and-error-related-fixes.patch, #41465 | |||
2017-08-08 | goldsimon | Status | None | In Progress | |
Assigned to | None | goldsimon | |||
2017-08-07 | dgirault | Attached File | - | Added 0005-altcp_tls_mbedtls-remove-rx-pbufs-left-at-end-of-han.patch, #41447 | |
2017-08-07 | dgirault | Attached File | - | Added 0001-altcp_tls_mbedtls-fix-log-messages-by-include-a-n.patch, #41443 | |
Attached File | - | Added 0002-altcp-fix-altcp_free.patch, #41444 | |||
Attached File | - | Added 0003-altcp_tcp-some-fixes.patch, #41445 | |||
Attached File | - | Added 0004-altcp_tls-some-fixes.patch, #41446 |
Powered by Savane 3.13-02a9.
Corresponding source code
Sorry, could you pass me to the function where I removed that?
In general, in (al-)TCP a layer should free its memory when it is closed. In the simple case of "app <-> tls <-> tcp", the inner_conn is tcp, which should free itself when both communication directions are closed.
Do you see memory leaks in this area?