lwIP - A Lightweight TCP/IP stack - Patches: patch #9498, Get rid of raw_flags() and...
You are not allowed to post comments on this tracker with your current authentication level.
patch #9498: Get rid of raw_flags() and udp_flags() macro
Submitter: | Axel Lin <axellin> | ||
Submitted: | Thu 23 Nov 2017 03:31:02 PM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | goldsimon | Open/Closed: | Closed |
Planned Release: | None |
Thu 23 Nov 2017 09:15:43 PM UTC, comment #1: |
Simon Goldschmidt <goldsimon> |
Thu 23 Nov 2017 03:31:02 PM UTC, original submission:
All current udp_flags() use cases can be replaced by udp_is_flag_set().
|
Axel Lin <axellin> |
Attached Files
file #42462: 0001-Get-rid-of-raw_flags-and-udp_flags-macro.patch added by axellin (3KiB - text/x-patch)
Depends on the following items: None found
Items that depend on this one: None found
Carbon-Copy List
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-11-23 | goldsimon | Status | None | Done | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed | |||
2017-11-23 | axellin | Attached File | - | Added 0001-Get-rid-of-raw_flags-and-udp_flags-macro.patch, #42462 |
Powered by Savane 3.13-02a9.
Corresponding source code
Pushed the sockets.c changes.
However, we can't just remove raw_flags() and udp_flags(). This is part of the API. raw/udp_setflags() are the corresponding setter functions (you didn't remove them either, and at least the udp part is actually used).
Just because the stack doesn't use it internally doesn't mean we can remove it.