lwIP - A Lightweight TCP/IP stack - Patches: patch #9624, TFTP server check block number of...
You are not allowed to post comments on this tracker with your current authentication level.
patch #9624: TFTP server check block number of DATA packets
Submitter: | Jens Nielsen <deft> | ||
Submitted: | Tue 24 Apr 2018 06:19:20 PM UTC | ||
Category: | apps | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | goldsimon | Open/Closed: | Closed |
Planned Release: | None |
Wed 25 Apr 2018 06:31:04 PM UTC, comment #2: |
Simon Goldschmidt <goldsimon> |
Wed 25 Apr 2018 03:44:21 PM UTC, comment #1: Hi,
|
Malte <malte> |
Tue 24 Apr 2018 06:19:20 PM UTC, original submission:
In a write transfer to the TFTP server, if the ack sent by lwip gets lost (or as in my case the application stalls when writing/erasing the internal flash and I can't send the ack in time) the client may retransmit the previous data packet. The current implementation will happily forward the same data again to the application which of course doesn't work.
|
Jens Nielsen <deft> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-04-25 | goldsimon | Status | None | Done | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed | |||
2018-04-25 | malte | Attached File | - | Added tftp_serverPackets.patch, #44029 | |
2018-04-24 | deft | Attached File | - | Added 0001-TFTP-server-handle-retransmit-Data-packets.patch, #44008 |
Powered by Savane 3.13-caa5.
Corresponding source code
The first one is better since it works for files > 32 mbytes (after a tiny fix that casts (blknum+1) to u16_t).
Pushed, thanks for the patch.