lwIP - A Lightweight TCP/IP stack - Bugs: bug #19222, timeout in sys_mbox_fetch
You are not allowed to post comments on this tracker with your current authentication level.
bug #19222: timeout in sys_mbox_fetch
Submitter: | Dmitry Potapov <dpotapov> | ||
Submitted: | Tue 06 Mar 2007 08:04:37 PM UTC | ||
Category: | sockets/netconn | Severity: | 3 - Normal |
Item Group: | Faulty Behaviour | Status: | Fixed |
Privacy: | Public | Assigned to: | fbernon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | None |
Jump to the original submission
Wed 11 Apr 2007 11:04:30 PM UTC, comment #19: |
Frédéric Bernon <fbernon> |
Wed 11 Apr 2007 04:47:55 AM UTC, comment #18: I have just two little comments on this change to sys_mbox_fetch. This function is now hard to follow for sure, so I may have slipped up. Nevertheless, in this block:
|
Jonathan Larmour <jifl> |
Fri 09 Mar 2007 10:43:48 AM UTC, comment #17:
|
Dmitry Potapov <dpotapov> |
Fri 09 Mar 2007 09:40:23 AM UTC, comment #16: Sorry, look "bug #1902 : Timeouts and semaphores/mailboxes are too tightly integrated" |
Frédéric Bernon <fbernon> |
Fri 09 Mar 2007 09:39:20 AM UTC, comment #15: Hi Dimtry,
|
Frédéric Bernon <fbernon> |
Thu 08 Mar 2007 10:36:45 PM UTC, comment #14: Hi Frédéric,
|
Dmitry Potapov <dpotapov> |
Thu 08 Mar 2007 09:07:26 PM UTC, comment #13: Hi Dimtry,
|
Frédéric Bernon <fbernon> |
Wed 07 Mar 2007 10:08:10 AM UTC, comment #12: Frédéric,
|
Dmitry Potapov <dpotapov> |
Wed 07 Mar 2007 09:45:52 AM UTC, comment #11: I currently work to enable/disable the code with LWIP_SO_RCVTIMEO, a provide a "fast" solution to Dmitry (and others). I will do real measures with both sys_mbox_fetch_with_timeout's implementations to know what is the best performance...
|
Frédéric Bernon <fbernon> |
Wed 07 Mar 2007 08:42:48 AM UTC, comment #10: You two had a real good and long conversation yesterday... :)
|
Simon Goldschmidt <goldsimon> |
Wed 07 Mar 2007 12:06:08 AM UTC, comment #9: Frédéric,
|
Dmitry Potapov <dpotapov> |
Tue 06 Mar 2007 11:30:39 PM UTC, comment #8: Don't worry Dmitry, I will fix that tomorrow morning (I don't want this new feature cause you any problems), but I hope other comments about that.
|
Frédéric Bernon <fbernon> |
Tue 06 Mar 2007 10:42:11 PM UTC, comment #7: Hi Frédéric,
|
Dmitry Potapov <dpotapov> |
Tue 06 Mar 2007 09:59:33 PM UTC, comment #6: Hey Dimtry, "overhead" is perhaps a too big word ? :)
|
Frédéric Bernon <fbernon> |
Tue 06 Mar 2007 09:07:24 PM UTC, comment #5: BTW, who said sys_arch_mbox_fetch() sets `msg' to NULL when it returns SYS_ARCH_TIMEOUT? I don't think that all ports do that. As result, you can end up with undefined value in `msg'. Of course, it is easy to fix by adding *msg = NULL at the beginning... but it just another indication that this approach is wrong...
|
Dmitry Potapov <dpotapov> |
Tue 06 Mar 2007 08:56:13 PM UTC, comment #4: I know that timeout handlers created per thread, but I don't like this implicit assumption that there is no timeout handlers in the thread that calls sys_arch_mbox_fetch with a finitive timeout.
|
Dmitry Potapov <dpotapov> |
Tue 06 Mar 2007 08:39:56 PM UTC, comment #3: Perhaps it will be better to change in sys.c, in sys_mbox_fetch, the line:
|
Frédéric Bernon <fbernon> |
Tue 06 Mar 2007 08:29:01 PM UTC, comment #2: In fact, no, the behavior is correct: timeouts have a processing priority but and except for netconn_recv, there is no change. At netconn or socket layer, there is no real timeouts handler defined (remember that timouts have to be created per thread).
|
Frédéric Bernon <fbernon> |
Tue 06 Mar 2007 08:13:56 PM UTC, comment #1: I am sorry for previous patch. I inadvertently upload a wrong (old) patch. |
Dmitry Potapov <dpotapov> |
Tue 06 Mar 2007 08:04:37 PM UTC, original submission:
The recently added `timeout' parameter to sys_mbox_fetch function is ignored when there are timeouts handlers, which seems to be incorrect behavior. Moreover, this parameter is used only in netconn_recv, where it can easily be implemented using sys_timeout().
|
Dmitry Potapov <dpotapov> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 7 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-04-11 | jifl | Attached File | - | Added sys.c.tweak.patch, #12462 | |
2007-03-09 | fbernon | Status | Works For Me | Fixed | |
Open/Closed | Open | Closed | |||
2007-03-08 | fbernon | Status | None | Works For Me | |
2007-03-06 | fbernon | Assigned to | None | fbernon | |
2007-03-06 | dpotapov | Attached File | - | Added sys_mbox_fetch-fix.patch, #12131 | |
2007-03-06 | dpotapov | Attached File | - | Added sys_mbox_fetch-fix.patch, #12130 |
Powered by Savane 3.13-caa5.
Corresponding source code
I'm far of my office, but I think your patch is ok...