lwIP - A Lightweight TCP/IP stack - Bugs: bug #20511, No persist timer
You are not allowed to post comments on this tracker with your current authentication level.
bug #20511: No persist timer
Submitter: | Kieran Mansley <kieranm> | ||
Submitted: | Wed 18 Jul 2007 09:31:50 AM UTC | ||
Category: | TCP | Severity: | 4 - Important |
Item Group: | Faulty Behaviour | Status: | Fixed |
Privacy: | Public | Assigned to: | kieranm |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | CVS Head |
Jump to the original submission
Fri 01 May 2009 12:27:41 PM UTC, comment #21: |
Kieran Mansley <kieranm> |
Thu 26 Mar 2009 02:43:09 PM UTC, comment #20: I've checked in a change to set the ACK flag on those probes. Can anyone confirm whether there is a still an outstanding issue with this bug? |
Kieran Mansley <kieranm> |
Thu 12 Feb 2009 01:39:13 PM UTC, comment #19: Status is: "not enough time at the moment"
|
Kieran Mansley <kieranm> |
Wed 11 Feb 2009 07:38:14 PM UTC, comment #18: Kieran, what's the status on this? It's still marked as planned for 1.3.0 ... |
Simon Goldschmidt <goldsimon> |
Thu 18 Dec 2008 02:57:33 PM UTC, comment #17: It is definitely lack of ACK flag in zero window probe.
|
Oleg Tyshev <olegreen> |
Fri 28 Nov 2008 10:23:02 AM UTC, comment #16: OK, I'll have to give that some thought. I think it would need some integration with the other parts of the tcp retransmission algorithm as it could result in a large number of packets being retransmitted, and so we should be updating some of the state. It has the potential to be harmful in that it could put packets onto the wire quite aggresively at a time of loss (i.e. when you should be backing off).
|
Kieran Mansley <kieranm> |
Fri 28 Nov 2008 10:06:19 AM UTC, comment #15: (A) This modification below resends the unacked segments till the send window allows.
|
Tamas Somogyi <tsomogyi> |
Thu 27 Nov 2008 02:08:09 PM UTC, comment #14: OK, reopening. I'll take another look when I get a chance, but not sure when that will be.
|
Kieran Mansley <kieranm> |
Thu 27 Nov 2008 01:23:03 PM UTC, comment #13: Kieran, the problem I described in bug #24212 caused by your last modification in tcp_out.c: Rev 1.71 works well, but I get the error using 1.72. The difference is that Zero Window Probe is sent not when snd_wnd is zero, but also when the window is not enough to send the data.
|
Tamas Somogyi <tsomogyi> |
Tue 04 Mar 2008 01:12:39 PM UTC, comment #12: Closing this as fixed due to lack of reports to the contrary. |
Kieran Mansley <kieranm> |
Tue 15 Jan 2008 01:02:38 PM UTC, comment #11: I've modified it to activate the persist timer when we're prevented from sending by a small send window (not just a zero send window).
|
Kieran Mansley <kieranm> |
Fri 04 Jan 2008 05:23:52 PM UTC, comment #10: If we receive whole sized packet, it will be trimmed till window size.
|
Oleg Tyshev <olegreen> |
Fri 04 Jan 2008 01:13:17 PM UTC, comment #9:
|
Kieran Mansley <kieranm> |
Fri 04 Jan 2008 12:53:21 PM UTC, comment #8: That is right.
|
Oleg Tyshev <olegreen> |
Thu 03 Jan 2008 08:54:00 AM UTC, comment #7: Thanks for taking a look.
|
Kieran Mansley <kieranm> |
Wed 02 Jan 2008 05:31:38 PM UTC, comment #6: Hi Kieran,
|
Oleg Tyshev <olegreen> |
Mon 31 Dec 2007 01:36:01 PM UTC, comment #5: I've checked this in, but again would like to see it more widely tested before we close this bug. |
Kieran Mansley <kieranm> |
Thu 20 Dec 2007 03:49:07 PM UTC, comment #4: I've merged and simplified the persist timer portion of the patch but I think this at least needs testing to make sure it doesn't break anything else before it can be committed. Any volunteers? I'm not in a position to test it myself at the moment and this is the last issue currently gating 1.3.0 |
Kieran Mansley <kieranm> |
Tue 18 Dec 2007 01:50:39 PM UTC, comment #3: (from lwip-users, by Per-Henrik Lundblom)
|
Frédéric Bernon <fbernon> |
Tue 06 Nov 2007 01:03:47 PM UTC, comment #2: (from bug #21522, by Oleg Tyshev)
|
Frédéric Bernon <fbernon> |
Thu 19 Jul 2007 01:06:16 AM UTC, comment #1: This problem can show up under the following circumstances:
|
Tom Evans <tom_evans> |
Wed 18 Jul 2007 09:31:50 AM UTC, original submission:
TCP implementations must have the persist timer to send zero-window probes allowing it to cope with a lost window update. We don't currently have one. Should be straightforward enough as rather similar to the keepalive probes and timer. |
Kieran Mansley <kieranm> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 11 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2009-05-01 | kieranm | Status | None | Fixed | |
Open/Closed | Open | Closed | |||
2009-02-12 | kieranm | Planned Release | 1.3.0 | 1.3.1 | |
2008-11-27 | kieranm | Status | Fixed | None | |
Open/Closed | Closed | Open | |||
2008-03-04 | kieranm | Status | Ready For Test | Fixed | |
Open/Closed | Open | Closed | |||
2007-12-31 | kieranm | Status | None | Ready For Test | |
2007-12-20 | kieranm | Attached File | - | Added persist_patch, #14676 | |
2007-12-18 | fbernon | Attached File | - | Added lwip_working.diff, #14652 | |
2007-08-29 | kieranm | Assigned to | None | kieranm |
Powered by Savane 3.13-02a9.
Corresponding source code
Closing as fixed (again) due to no reports to the contrary.