lwIP - A Lightweight TCP/IP stack - Bugs: bug #27504, tcp_enqueue wrongly concatenates...
You are not allowed to post comments on this tracker with your current authentication level.
bug #27504: tcp_enqueue wrongly concatenates segments which are not consecutive when retransmitting unacked segments
Submitter: | Jörg Kesten <jkesten> | ||
Submitted: | Wed 23 Sep 2009 09:02:49 AM UTC | ||
Category: | TCP | Severity: | 3 - Normal |
Item Group: | Faulty Behaviour | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | 1.3.1 |
Sun 11 Oct 2009 01:07:21 PM UTC, comment #2: |
Simon Goldschmidt <goldsimon> |
Wed 23 Sep 2009 10:32:52 AM UTC, comment #1: The patch looks good to me.
|
Jakob Stoklund Olesen <stoklund> |
Wed 23 Sep 2009 09:02:49 AM UTC, original submission:
tcp_enqueue tries to append a new segment to the last one in the unsent list if the max len is not reached yet.
- one segment (number n) is in the unsent queue
|
Jörg Kesten <jkesten> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2009-10-11 | goldsimon | Status | None | Fixed | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed | |||
2009-09-23 | jkesten | Attached File | - | Added tcp_enqueue.patch, #18759 |
Powered by Savane 3.13-f8d8.
Corresponding source code
That would also be faster than adding the segment to the unsent list, but if direct sending fails (e.g. due to ERR_MEM), the segment won't be sent again until the next call to the timer.
I prefer the patch as a solution as it does not change the behaviour much.
Checked in, thanks for reporting.