bugGPSD - Bugs: bug #36919, "scons valgrind-audit"...

 
 

bug #36919: "scons valgrind-audit" (only) audits sytem-installed gpsd binary

Submitted by:  Olivier Cornu <ocornu>
Submitted on:  Sun 22 Jul 2012 05:26:17 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Eric S. Raymond <esr>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 22 Jul 2012 07:43:00 PM UTC, comment #2:

Here's a patch that implements it.

Note: it should be applied after patch #26237, addressing another valgrind build issue (bug #36914).

(file #26245)

Olivier Cornu <ocornu>
Sun 22 Jul 2012 05:30:26 PM UTC, comment #1:

I suppose the expected behavior would be to always audit the local instance, building it if necessary.
In other words, patch SConstruct to:

  • set GPSD_HOME=`pwd`
  • honor valgrind-audit dependency on gpsd
Olivier Cornu <ocornu>
Sun 22 Jul 2012 05:26:17 PM UTC, original submission:

valgrind-audit depends on fake.py to spawn a gpsd daemon.
fake.py uses the GPSD_HOME variable to locate a gpsd binary. However, SConstruct does not set GPSD_HOME, nor does it import it straight from the environment. Thus, fake.py falls back on the PATH mechanism.

As it is:

  • If there is a system/installed gpsd binary, it is always used (unless '.' comes first in PATH).
  • If there is none:
    • If '.' is in PATH, local just-built gpsd binary is used.
    • if '.' is not in PATH, valgrind-audit fails.

It obviously isn't "scons valgrind-audit" expected behavior.

Olivier Cornu <ocornu>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #26245:  commit-12cc93f added by ocornu (1KiB - application/octet-stream - Force valgrind audit of local build)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by esr (Updated the item)
  • -unavailable- added by ocornu (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 09 Sep 2012 06:55:14 PM UTCesrOpen/ClosedOpen=>Closed
    Tue 31 Jul 2012 05:14:29 AM UTCesrStatusNone=>Fixed
      Assigned toNone=>esr
    Sun 22 Jul 2012 07:43:00 PM UTCocornuAttached File-=>Added commit-12cc93f, #26245

    Back to the top


    Powered by Savane 3.1-cleanup1