bugGPSD - Bugs: bug #36919, "scons valgrind-audit"...

 
 

bug #36919: "scons valgrind-audit" (only) audits sytem-installed gpsd binary

Submitter:  Olivier Cornu <ocornu>
Submitted:  Sun 22 Jul 2012 05:26:17 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  esr
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 22 Jul 2012 07:43:00 PM UTC, comment #2: 

Here's a patch that implements it.

Note: it should be applied after patch #26237, addressing another valgrind build issue (bug #36914).

(file #26245)

Olivier Cornu <ocornu>
Sun 22 Jul 2012 05:30:26 PM UTC, comment #1: 

I suppose the expected behavior would be to always audit the local instance, building it if necessary.
In other words, patch SConstruct to:

  • set GPSD_HOME=`pwd`
  • honor valgrind-audit dependency on gpsd
Olivier Cornu <ocornu>
Sun 22 Jul 2012 05:26:17 PM UTC, original submission:  

valgrind-audit depends on fake.py to spawn a gpsd daemon.
fake.py uses the GPSD_HOME variable to locate a gpsd binary. However, SConstruct does not set GPSD_HOME, nor does it import it straight from the environment. Thus, fake.py falls back on the PATH mechanism.

As it is:

  • If there is a system/installed gpsd binary, it is always used (unless '.' comes first in PATH).
  • If there is none:
    • If '.' is in PATH, local just-built gpsd binary is used.
    • if '.' is not in PATH, valgrind-audit fails.

It obviously isn't "scons valgrind-audit" expected behavior.

Olivier Cornu <ocornu>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #26245:  commit-12cc93f added by ocornu (1KiB - application/octet-stream - Force valgrind audit of local build)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by esr (Updated the item)
  • -email is unavailable- added by ocornu (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-09-09 esr Open/ClosedOpen Closed
    2012-07-31 esr StatusNone Fixed
        Assigned toNone esr
    2012-07-22 ocornu Attached File- Added commit-12cc93f, #26245

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code