lwIP - A Lightweight TCP/IP stack - Bugs: bug #43173, pppos_input() corrupts memory if...
You are not allowed to post comments on this tracker with your current authentication level.
bug #43173: pppos_input() corrupts memory if IP_FORWARD is enabled
| Submitter: | Ivan Delamer <idelamer> | ||
| Submitted: | Mon 08 Sep 2014 05:16:08 PM UTC | ||
| Category: | PPP | Severity: | 4 - Important |
| Item Group: | Crash Error | Status: | Fixed |
| Privacy: | Public | Assigned to: | None |
| Open/Closed: | Closed | Planned Release: | None |
| lwIP version: | git head | ||
Jump to the original submission
|
Sun 12 Oct 2014 04:42:50 PM UTC, comment #6: |
Sylvain Rochet <gradator> |
|
Fri 19 Sep 2014 04:34:01 AM UTC, comment #5: I'm traveling so I can test this next week, although I don't have a PPP->Ethernet forwarding scenario. I can still test that it doesn't crash. |
Ivan Delamer <idelamer> |
|
Wed 17 Sep 2014 07:33:10 PM UTC, comment #4: Here's a patch of how I would fix it.
|
Simon Goldschmidt <goldsimon> |
|
Tue 16 Sep 2014 08:14:15 PM UTC, comment #3: I have a fix where I allocate PBUF_LINK_HLEN as 'len' for the first pbuf (head only) and hide it before passing to pppos_input_callback. However, I cannot test it. If you could test it, I'd just commit it (it compiles, so...) |
Simon Goldschmidt <goldsimon> |
|
Tue 16 Sep 2014 07:53:50 PM UTC, comment #2: OK, rings a bell, I had lightly followed that discussion.
|
Ivan Delamer <idelamer> |
|
Tue 16 Sep 2014 06:44:32 PM UTC, comment #1: The commit was a result of a discussion on lwip-users, see
|
Simon Goldschmidt <goldsimon> |
|
Mon 08 Sep 2014 05:16:08 PM UTC, original submission:
This was introduced in commit 4283ecf7748ccf7ab41fc09b7d6d4acb1f7f4444
|
Ivan Delamer <idelamer> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Oh dear, looks like I have been trapped by the custom way the PPPoS stack is dealing with PBUF.
Anyway, I carefully checked and tested the proposed patch, and it works, thank you ;-)