buglwIP - A Lightweight TCP/IP stack - Bugs: bug #55537, Crash in SYN_SENT state when...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #55537: Crash in SYN_SENT state when TCP_INPUT_DEBUG logs are ON

Submitter:  Puneet <puneetsharma>
Submitted:  Mon 21 Jan 2019 12:05:46 PM UTC
   
 
Category:  TCP Severity:  3 - Normal
Item Group:  Crash Error Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Planned Release:  None
lwIP version:  2.0.3

Wed 30 Jan 2019 01:27:48 PM UTC, comment #5: 

I've improved the debug message a little

Simon Goldschmidt <goldsimon>
Group administrator
Mon 28 Jan 2019 01:35:48 PM UTC, comment #4: 

Correction!!!
Mon 28 Jan 2019 01:25:29 PM UTC, comment #3:
Zero may not be correct ACK number in case pcb->unacked list is NULL.
I suggest :
LWIP_DEBUGF(TCP_INPUT_DEBUG, ("SYN-SENT: ackno %"U32_F" pcb->snd_nxt %"U32_F" unacked %"U32_F"\n", ackno,
pcb->snd_nxt, (pcb->lastack + 1)));

Puneet <puneetsharma>
Mon 28 Jan 2019 01:25:29 PM UTC, comment #3: 

Zero may not correct ACK number in case pcb->unacked list is NULL.
I suggest :
    LWIP_DEBUGF(TCP_INPUT_DEBUG, ("SYN-SENT: ackno %"U32_F" pcb->snd_nxt %"U32_F" unacked %"U32_F"\n", ackno,
     pcb->snd_nxt, (pcb->lastack + 1)));

Puneet <puneetsharma>
Mon 28 Jan 2019 01:21:49 PM UTC, comment #2: 

Fixed, thanks for reporting!

Dirk Ziegelmeier <dziegel>
Group administrator
Mon 21 Jan 2019 01:34:13 PM UTC, comment #1: 

No need to mark this private when it only happens for TCP_INPUT_DEBUG.

Simon Goldschmidt <goldsimon>
Group administrator
Mon 21 Jan 2019 12:05:46 PM UTC, original submission:  

Scenario:
SYN---->
SYN re-retransmission--->fails...
SYN_ACK received in SYN_SENT received

pcb->unacked list is NULL, yet debug log tries refer pcb->unacked->tcphdr


Puneet <puneetsharma>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #46057:  syn_retransmission_failure.patch added by puneetsharma (767B - application/octet-stream - Attached fix)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dziegel (Posted a comment)
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by puneetsharma (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-01-28 dziegel StatusNone Fixed
        Open/ClosedOpen Closed
    2019-01-21 goldsimon PrivacyPrivate Public
    2019-01-21 puneetsharma Attached File- Added syn_retransmission_failure.patch, #46057

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code