bugAVR Downloader/UploaDEr - Bugs: bug #57338, if safemode has to change fuses...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #57338: if safemode has to change fuses avrdude should exit with non-zero exit code

Submitted by:  None
Submitted on:  Sun 01 Dec 2019 11:02:58 PM UTC  
 
Category:  None Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  None Privacy:  Public
Assigned to:  None Originator Name:  Britton Kerin
Originator Email:  -email is unavailable- Open/Closed:  Open
Release:  6.3 Programmer hardware:  all
Device type:  any except AVR32, Xmega or TPI

Sun 01 Dec 2019 11:02:58 PM UTC, original submission:  

There's a fuses_specified variable in main that gets initialized to zero and never changed, and then there's this code at the end
of the fusemode recovery block:

    if (fuses_updated && fuses_specified) {
      exitrc = 1;
    }

So it looks like maybe the intention was to exit with non-zero if the user requested a fuse change (but fuses_specified isn't getting set in this case) but avrdude had to back it out due to fuses not being as expected.

IMO the correct thing to do is to always exit with a non-zero code if safe mode is doing any fuse recovery at all, regardless of whether any fuse changes were requested.  With some other patches that I'm about to submit this should be possible because safemode shouldn't trigger when -V is used anymore.

Anonymous

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    No changes have been made to this item

    Back to the top


    Powered by Savane 3.5