buglwIP - A Lightweight TCP/IP stack - Bugs: bug #58139, RFC5227 violation in acd module

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #58139: RFC5227 violation in acd module

Submitted by:  Jasper Verschueren <jasperv>
Submitted on:  Wed 08 Apr 2020 08:37:11 AM UTC  
 
Category:  IPv4 Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open Planned Release:  None
lwIP version:  git head

Tue 12 May 2020 12:59:14 PM UTC, comment #3: 

Hi David,

It could indeed be that commit 05ffe144 was enough to fix the BCT failure.
From an RFC standpoint we need to revert this commit.

I'm not sure what the effort is to run the BCT on this, but could you verify if it still passes after the revert?

Kind regards,
Jasper

Jasper Verschueren <jasperv>
Thu 09 Apr 2020 09:53:11 AM UTC, comment #2: 

Hi Jasper and Simon,

I've made this change to allow our product to pass the Apple Bonjour Conformance Test (BCT).

May be the fix was incorrect, but it was the only one I found to be able to pass the BCT if some announce are lost because wifi connection.

I don't found exactly why this change was introduced one year ago in our tickets database. :-/

But according to my BCT logs at Jun 21 2019, before introducing this fix Jun 25 2119 in our GIT branch, I had the following errors:

Link-Local Address Allocation
-----------------------------
        PASSED: INITIAL PROBING
        PASSED: PROBING: RATE LIMITING
        PASSED: PROBING: CONFLICTING SIMULTANEOUS PROBES
        PASSED: PROBING: PROBE DENIALS
        PASSED: PROBING
        PASSED: PROBING COMPLETION
        WARNING: SUBSEQUENT CONFLICTS: RE-PROBE AFTER FIRST CONFLICT
        FAILED: SUBSEQUENT CONFLICTS: ANNOUNCEMENTS
        FAILED: SUBSEQUENT CONFLICTS
        ABORTED: CABLE CHANGE HANDLING
        PASSED: PREMATURE MDNS PROBING
FAILED with 2 failed subtest(s) and 1 aborted subtest(s) and 1 warning(s) and 0 skipped subtest(s).

May be this fix wasn't necessary and commit 05ffe144 is enough to fix BCT.

So, if this specific commit break conformance to the RFC, just revert it. If we need to update adn redo the BCT later, I'll take care of this.

Regards,
David

David GIRAULT <dgirault>
Thu 09 Apr 2020 07:40:32 AM UTC, comment #1: 

I've added David Girault to CC, since he did that commit

Simon Goldschmidt <goldsimon>
Project Administrator
Wed 08 Apr 2020 08:37:11 AM UTC, original submission:  

According to RFC5227 section 2.3: The host may begin legitimately using the IP address immediately after sending the first of the two ARP Announcements; the sending of the second ARP Announcement may be completed asynchronously, concurrent with other networking operations the host may wish to perform.

This behavior is recently changed by commit 30d445bd acd: inform address is good only when going in ongoing state.
Currently we only let the acd user know that the address is good after all announce messages have been send.

So I request to revert this commit.

Jasper Verschueren <jasperv>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dgirault (Posted a comment)
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by goldsimon
  • -email is unavailable- added by jasperv (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-04-09 goldsimon Carbon-Copy- => Added dgirault@sevenhugs.com

    Back to the top


    Powered by Savane 3.6