bugAdvanced Gtk+ Sequencer - Bugs: bug #58412, (process:35515):...

 
 

bug #58412: (process:35515): GLib-GObject-WARNING **: 14:36:58.820: invalid cast from 'AgsApplicationContext' to 'AgsConcurrencyProv

Submitted by:  Andreas Schwab <schwab>
Submitted on:  Wed 20 May 2020 03:10:43 PM UTC  
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Ready For Test
Privacy:  Public Assigned to:  Joël Krähemann <jkraehemann>
Open/Closed:  Open

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Thu 21 May 2020 03:34:21 AM UTC, comment #10: 
Joël Krähemann <jkraehemann>
Project AdministratorIn charge of this item.
Thu 21 May 2020 03:25:56 AM UTC, comment #9: 

The ags-fx code should be programmed in a safe way ... It should be able to deal with a NULL pointer.

I just check the code and improved the test.

http://git.savannah.nongnu.org/cgit/gsequencer.git/tree/ags/test/audio/fx/ags_fx_buffer_audio_signal_test.c?h=3.3.x

There are no more warnings :-)

Joël Krähemann <jkraehemann>
Project AdministratorIn charge of this item.
Wed 20 May 2020 06:44:24 PM UTC, comment #8: 

You are commiting the worst sin in programming: ignoring undefined behavour.

Andreas Schwab <schwab>
Wed 20 May 2020 05:42:15 PM UTC, comment #7: 

As shown on my screen the unit-test just passes.

Joël Krähemann <jkraehemann>
Project AdministratorIn charge of this item.
Wed 20 May 2020 05:34:44 PM UTC, comment #6: 

Hi, see attached picture.


Joël Krähemann <jkraehemann>
Project AdministratorIn charge of this item.
Wed 20 May 2020 05:32:18 PM UTC, comment #5: 

I am just running the tests on my Raspberry Pi 4B ...

I take a look at it. Please tell me what version are you using?

Joël Krähemann <jkraehemann>
Project AdministratorIn charge of this item.
Wed 20 May 2020 05:19:59 PM UTC, comment #4: 

$ ./ags_fx_buffer_audio_signal_test

     CUnit - A unit testing framework for C - Version 2.1-3
     http://cunit.sourceforge.net/

Suite: AgsFxBufferAudioSignalTest
  Test: test of AgsFxBufferAudioSignal new ...passed
  Test: test of AgsFxBufferAudioSignal run inter ...
(process:26009): GLib-GObject-CRITICAL **: 17:18:45.741: g_object_get: assertion 'G_IS_OBJECT (object)' failed

(process:26009): GLib-GObject-CRITICAL **: 17:18:45.741: g_object_get: assertion 'G_IS_OBJECT (object)' failed

(process:26009): GLib-GObject-CRITICAL **: 17:18:45.741: g_object_get: assertion 'G_IS_OBJECT (object)' failed

(process:26009): GLib-GObject-CRITICAL **: 17:18:45.741: g_object_get: assertion 'G_IS_OBJECT (object)' failed

(process:26009): GLib-GObject-CRITICAL **: 17:18:45.741: g_object_get: assertion 'G_IS_OBJECT (object)' failed

    • (process:26009): CRITICAL **: 17:18:45.741: ags_recycling_remove_audio_signal: assertion 'AGS_IS_RECYCLING(recycling) && AGS_IS_AUDIO_SIGNAL(audio_signal)' failed

(process:26009): GLib-GObject-CRITICAL **: 17:18:45.741: g_object_get: assertion 'G_IS_OBJECT (object)' failed

(process:26009): GLib-GObject-CRITICAL **: 17:18:45.742: g_object_get: assertion 'G_IS_OBJECT (object)' failed

(process:26009): GLib-GObject-CRITICAL **: 17:18:45.742: g_object_get: assertion 'G_IS_OBJECT (object)' failed

(process:26009): GLib-GObject-CRITICAL **: 17:18:45.742: g_object_get: assertion 'G_IS_OBJECT (object)' failed

(process:26009): GLib-GObject-CRITICAL **: 17:18:45.742: g_object_get: assertion 'G_IS_OBJECT (object)' failed

    • (process:26009): CRITICAL **: 17:18:45.742: ags_recycling_remove_audio_signal: assertion 'AGS_IS_RECYCLING(recycling) && AGS_IS_AUDIO_SIGNAL(audio_signal)' failed
Andreas Schwab <schwab>
Wed 20 May 2020 05:17:25 PM UTC, comment #3: 

That doesn't change anything.

Andreas Schwab <schwab>
Wed 20 May 2020 03:54:23 PM UTC, comment #2: 

Thank you!

Joël Krähemann <jkraehemann>
Project AdministratorIn charge of this item.
Wed 20 May 2020 03:53:36 PM UTC, comment #1: 

I am not sure what you want, maybe this:

http://git.savannah.nongnu.org/cgit/gsequencer.git/commit/?h=3.3.x&id=cb78dce21694d8d2a2b860ce6e00fec04109d54a

Note, the unit-test doesn't instantiate any application context. This is why we get this warning. As long it doesn't crash I don't really care. Maybe I will fix this.

Anyhow, if you experienced a SIGSEGV take a look at the pointer corruption because of a wrong argument to an type cast.

I think it is fixed as of version 3.3.3

@@ -187,7 +187,7 @@ ags_fx_peak_audio_signal_real_run_inter(AgsRecall *recall)
      sound_scope >= 0 &&
      sound_scope < AGS_SOUND_SCOPE_LAST){
     fx_peak_channel_mutex = AGS_RECALL_GET_OBJ_MUTEX(fx_peak_channel);
-    stream_mutex = AGS_AUDIO_SIGNAL_GET_STREAM_MUTEX(fx_peak_channel);
+    stream_mutex = AGS_AUDIO_SIGNAL_GET_STREAM_MUTEX(source);

     g_rec_mutex_lock(fx_peak_channel_mutex);
     g_rec_mutex_lock(stream_mutex);

Joël Krähemann <jkraehemann>
Project AdministratorIn charge of this item.
Wed 20 May 2020 03:10:43 PM UTC, original submission:  

$ ./ags_fx_peak_audio_signal_test

     CUnit - A unit testing framework for C - Version 2.1-3
     http://cunit.sourceforge.net/

Suite: AgsFxPeakAudioSignalTest
  Test: test of AgsFxPeakAudioSignal new ...passed
  Test: test of AgsFxPeakAudioSignal run inter ...
(process:35671): GLib-GObject-WARNING **: 14:38:16.074: invalid cast from 'AgsApplicationContext' to 'AgsConcurrencyProvider'

    • (process:35671): CRITICAL **: 14:38:16.074: ags_concurrency_provider_get_task_launcher: assertion 'AGS_IS_CONCURRENCY_PROVIDER(concurrency_provider)' failed

(process:35671): GLib-GObject-CRITICAL **: 14:38:16.074: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

Andreas Schwab <schwab>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #49133:  raspberry-pi-everything-fine.png added by jkraehemann (290KiB - image/png - My pi passing the tests)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jkraehemann (Posted a comment)
  • -email is unavailable- added by schwab (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-06-14 jkraehemann StatusNone => Ready For Test
    2020-05-21 jkraehemann Assigned toNone => jkraehemann
    2020-05-20 jkraehemann Attached File- => Added raspberry-pi-everything-fine.png, #49133

    Back to the top


    Powered by Savane 3.5