buglwIP - A Lightweight TCP/IP stack - Bugs: bug #59866, wrong comment in file fs_example.c

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #59866: wrong comment in file fs_example.c

Submitter:  Andrey Vinogradov <andreyvinogradov>
Submitted:  Wed 13 Jan 2021 03:46:46 PM UTC
   
 
Category:  Documentation Severity:  3 - Normal
Item Group:  Change Request Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  2.2.0
lwIP version:  git head

Sat 30 Jan 2021 09:14:12 PM UTC, comment #1: 

Fixed as suggested, thanks for reporting!

Simon Goldschmidt <goldsimon>
Group administrator
Wed 13 Jan 2021 03:46:46 PM UTC, original submission:  

There is an example of fs_wait_read_custom() function definition:
u8_t
fs_wait_read_custom(struct fs_file *file, fs_wait_cb callback_fn, void *callback_arg)
{
...

  /* Return
     - 1 if ready to read (at least one byte)
     - 0 if reading should be delayed (call 'tcpip_callback(callback_fn, callback_arg)' when ready) */

  return 1;
}

probably 0 and 1 return values are messed up in comment and it should be:
  /* Return
     - 0 if ready to read (at least one byte)
     - 1 if reading should be delayed (call 'tcpip_callback(callback_fn, callback_arg)' when ready) */

Andrey Vinogradov <andreyvinogradov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by andreyvinogradov (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-01-30 goldsimon StatusNone Fixed
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
        Planned ReleaseNone 2.2.0

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code