lwIP - A Lightweight TCP/IP stack - Bugs: bug #59876, HTTPD FS: in struct fs_file,...
You are not allowed to post comments on this tracker with your current authentication level.
bug #59876: HTTPD FS: in struct fs_file, pextension duplicates LWIP_HTTPD_FILE_STATE functionality
Submitter: | Mike Kleshov <kleshov> | ||
Submitted: | Fri 15 Jan 2021 06:03:56 AM UTC | ||
Category: | apps | Severity: | 2 - Minor |
Item Group: | Change Request | Status: | Fixed |
Privacy: | Public | Assigned to: | kleshov |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | git head |
Thu 28 Jan 2021 05:30:50 AM UTC, comment #5: |
Mike Kleshov <kleshov> |
Wed 27 Jan 2021 08:16:39 PM UTC, comment #4: Seems good to me! |
Simon Goldschmidt <goldsimon> |
Wed 27 Jan 2021 04:58:30 PM UTC, comment #3: Here is the proposed change:
|
Mike Kleshov <kleshov> |
Mon 25 Jan 2021 08:05:27 PM UTC, comment #2: Wrapping pextension in a config macro seems like the right way to go. I'll put together a patch soon so we can discuss it. |
Mike Kleshov <kleshov> |
Mon 25 Jan 2021 07:32:10 PM UTC, comment #1: You're probably right in that it's not really required. But to ensure backwards compatibility, can we first make it conditional for some time (proabably combined with an #error that can be disabled, so that people know what to change)? |
Simon Goldschmidt <goldsimon> |
Fri 15 Jan 2021 06:03:56 AM UTC, original submission:
I wonder what can be done with pextension that cannot be done with LWIP_HTTPD_FILE_STATE? And one cannot disable it with a config macro. I suggest removing pextension altogether. |
Mike Kleshov <kleshov> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2021-01-28 | kleshov | Status | None | Fixed | |
Assigned to | None | kleshov | |||
Open/Closed | Open | Closed |
Powered by Savane 3.13-aa77.
Corresponding source code
Comitted, thank you for your feedback!