buglwIP - A Lightweight TCP/IP stack - Bugs: bug #60578, If no gateway is provided via...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #60578: If no gateway is provided via DHCP, lwIP will fallback to the first address

Submitter:  Patrik Lantto <patriklantto>
Submitted:  Tue 11 May 2021 09:01:28 AM UTC
   
 
Category:  DHCP Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  None
lwIP version:  git head

Jump to the original submission

Fri 24 Sep 2021 05:44:59 AM UTC, comment #7: 

Yes.

Simon Goldschmidt <goldsimon>
Group administrator
Thu 23 Sep 2021 09:50:06 PM UTC, comment #6: 

Should we include this in STABLE-2_1_x ?

Erik Ekman <yarrick>
Group Member
Fri 14 May 2021 08:33:50 AM UTC, comment #5: 

Removed the fallback. Thanks for reporting.

Simon Goldschmidt <goldsimon>
Group administrator
Thu 13 May 2021 11:59:07 AM UTC, comment #4: 

Removing the fallback sounds good.

Erik Ekman <yarrick>
Group Member
Wed 12 May 2021 07:53:19 PM UTC, comment #3: 

I wondered the same, but not being sure what the policy on removing functionality from lwIP looked like, I played it safe and suggested a define...

But honestly, I do not expect anyone would still be dependent on this - I have not found any references that this would be a previously defined fallback behaviour, and a DHCP server that does not set a gateway is most probably configured so by purpose (which was the case for us).

So my vote - despite the suggested patch - would be to remove the code.

Patrik Lantto <patriklantto>
Wed 12 May 2021 07:38:48 PM UTC, comment #2: 

I wonder if it's really worth to add a define for this. I think I'd rather remove this code. Or is there some bogus requirement for this in the RFC or some old system's DHCP server?

Simon Goldschmidt <goldsimon>
Group administrator
Tue 11 May 2021 10:07:58 AM UTC, comment #1: 

Patch changing the default behaviour attached to not set a default gateway if none provided by DHCP is attached.

(file #51418)

Patrik Lantto <patriklantto>
Tue 11 May 2021 09:01:28 AM UTC, original submission:  

If DHCP does not provide a gateway, lwIP will still set the first address of the network as gateway for the netif.

It is probably very uncommon for a DHCP server not to set a gateway, but if the functionality to "guess" a gateway should remain in lwIP, it should at least not be the default behaviour as it otherwise may cause issues - especially on systems with multiple netifs.

Patrik Lantto <patriklantto>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #51418:  60578-dhcp-gateway.patch added by patriklantto (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by yarrick (Posted a comment)
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by patriklantto (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-05-14 goldsimon StatusNone Fixed
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2021-05-11 patriklantto Attached File- Added 60578-dhcp-gateway.patch, #51418

    Back to the top

    Powered by Savane 3.13-bb6a.
    Corresponding source code