buglwIP - A Lightweight TCP/IP stack - Bugs: bug #61152, Compiler Flags adjustments

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #61152: Compiler Flags adjustments

Submitted by:  Florian La Roche <flaroche>
Submitted on:  Mon 13 Sep 2021 10:08:22 AM UTC
 
Category:  Platform ports Severity:  3 - Normal
Item Group:  Compiler Warning Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  None
lwIP version:  * git head
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Fri 12 Nov 2021 09:41:05 PM UTC, comment #2: 

Already fixed -> closing

Simon Goldschmidt <goldsimon>
Project Administrator
Sun 03 Oct 2021 10:48:00 AM UTC, comment #1: 

CmakeCommon.cmake adds Wredundant-decls in case MbedTLS is not used (line 70):

if (NOT LWIP_HAVE_MBEDTLS)
    list(APPEND LWIP_COMPILER_FLAGS_GNU_CLANG
        -Wredundant-decls
        $<$<COMPILE_LANGUAGE:C>:-Wc++-compat>
    )
endif()

(although I dont know Cmake stuff that well)

You are correct that Common.allports.mk has it twice. Pushing your change to fix it. Thanks!

Erik Ekman <yarrick>
Project Member
Mon 13 Sep 2021 10:08:22 AM UTC, original submission:  

In the file contrib/ports/CMakeCommon.cmake -Wredundant-decls
is missing.

In the file contrib/ports/Common.allports.mk -Wredundant-decls
is given twice, so one can be deleted.

best regards and thanks for lwip,

Florian La Roche

Florian La Roche <flaroche>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #51903:  lwip-redundant-decls.patch added by flaroche (1KiB - text/x-patch - compiler flags adjusted)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by yarrick (Posted a comment)
  • -email is unavailable- added by flaroche (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-11-12 goldsimon StatusNone => Fixed
        Assigned toNone => goldsimon
        Open/ClosedOpen => Closed
    2021-09-13 flaroche Attached File- => Added lwip-redundant-decls.patch, #51903

    Back to the top


    Powered by Savane 3.9