buglwIP - A Lightweight TCP/IP stack - Bugs: bug #61663, PPP Debugging

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #61663: PPP Debugging

Submitted by:  Ashley Duncan <ashesman>
Submitted on:  Sun 12 Dec 2021 09:17:48 PM UTC
 
Category:  PPP Severity:  3 - Normal
Item Group:  Change Request Status:  None
Privacy:  Public Assigned to:  gradator
Open/Closed:  Open Planned Release:  None
lwIP version:  * git head
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Sun 12 Dec 2021 10:42:47 PM UTC, comment #2: 

Yeah, this debug comes from pppd. No one really have to enable this debug trace unless the PPP code itself is suspected to be faulty, so I basically would be the one and only potential user of it.

Sylvain Rochet <gradator>
Project Member
Sun 12 Dec 2021 10:06:00 PM UTC, comment #1: 

Sorry, please make that pppdebug.h line 60

Ashley Duncan <ashesman>
Sun 12 Dec 2021 09:17:48 PM UTC, original submission:  

Hi,

A very minor issue...  When trying to enable PPP debugging, I noticed two problems:

The macros defined in ppp.h around line 60

#define IPCPDEBUG(a)    LWIP_DEBUGF(LWIP_DBG_LEVEL_WARNING, a)

are not correct I don't think as they always prevent enabling debug output.  I think they should be

#define IPCPDEBUG(a)    LWIP_DEBUGF(PPP_DEBUG, a)

Secondly, uses of these macros have no newlines in the debug output which is inconsistent with all other uses of LWIP_DEBUGF.  Example is

IPCPDEBUG(("ipcp: up"));

Ashley Duncan <ashesman>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gradator (Posted a comment)
  • -email is unavailable- added by ashesman (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-12-12 gradator Assigned toNone => gradator

    Back to the top


    Powered by Savane 3.9