bugCERTI - Bugs: bug #24294, crash after...

 
 

bug #24294: crash after MessageBuffer::read/write_...s() with zero length

Submitter:  Petr Gotthard <gotthardp>
Submitted:  Thu 18 Sep 2008 09:21:23 AM UTC
   
 
Category:  CERTI Severity:  * 4 - Important
Item Group:  Software error Status:  Ready For Test
Privacy:  Public Assigned to:  gotthardp
Open/Closed:  Closed Release:  * CVS
Reproducibility:  Every Time Fixed Release:  * 3.3.1
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 18 Sep 2008 02:43:43 PM UTC, comment #2: 

Fixed.

Petr Gotthard <gotthardp>
Group Member
Thu 18 Sep 2008 10:28:55 AM UTC, comment #1: 

I think yes we should:

data[0] may be replaced by:

data==NULL ? 0 : data[0]

concerning performance you are right,
but in debug the first data is insightful :=)

I think that debugging output should be suppressed
alltogether when not compiling in debug mode.
Current "PrettyPrinter" class is not made like this
but we may change this in the future
in order to have better performance for CERTI
compiled for "Release".

Eric NOULARD <erk>
Group administrator
Thu 18 Sep 2008 09:21:23 AM UTC, original submission:  

The read/write_...s functions have a debug output that print first element in the field that has been saved/loaded (data[0]). If the list is empty (len=0) this may cause segmentation fault.

Should we add a condition (that affects the performance) or stop printing first element?

Petr Gotthard <gotthardp>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by erk (Posted a comment)
  • -email is unavailable- added by gotthardp (Submitted the item)
  •  

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-09-21 erk Open/ClosedOpen Closed
        Fixed ReleaseUnknown 3.3.1
    2008-09-18 gotthardp StatusNone Ready For Test
        Assigned toNone gotthardp

    Back to the top

    Powered by Savane 3.13-cf05.
    Corresponding source code