patchlwIP - A Lightweight TCP/IP stack - Patches: patch #10122, mqtt_disconnect(): Correctly send...


You are not allowed to post comments on this tracker with your current authentication level.

patch #10122: mqtt_disconnect(): Correctly send MQTT_MSG_TYPE_DISCONNECT

Submitter:  Christian Schlotter <schlotter>
Submitted:  Thu 14 Oct 2021 08:31:17 PM UTC
Category:  apps Priority:  5 - Normal
Status:  Need Info Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Open
Planned Release:  None

Thu 12 Oct 2023 07:55:35 PM UTC, comment #3: 

This patch seems wrong in that it checks for space using 'mqtt_output_check_space(..., 0) != 0' but then calls 'mqtt_output_append_fixed_header()' which appends 2 bytes?

Simon Goldschmidt <goldsimon>
Group administrator
Fri 15 Oct 2021 07:10:35 AM UTC, comment #2: 

Please find attached a new patch which applies to git master instead of git STABLE-2_1_x.

(file #52100)

Christian Schlotter <schlotter>
Fri 15 Oct 2021 05:47:29 AM UTC, comment #1: 

The patch does not seem to apply to git master. Please provide patches on top of master. The 2.1.x branch only gets cherry-picked fixes.

Simon Goldschmidt <goldsimon>
Group administrator
Thu 14 Oct 2021 08:31:17 PM UTC, original submission:  

Fixes bug #59313 by sending MQTT_MSG_TYPE_DISCONNECT when mqtt_disconnect() is called. Previously, just the TCP connection was closed which results in an ungraceful disconnection from the MQTT Broker.

Patch applies to origin/STABLE-2_1_x.

Christian Schlotter <schlotter>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #52100:  0001-PATCH-Fix-bug-59313-Possible-faulty-behavior-in-mqtt-master.patch added by schlotter (1KiB - application/octet-stream - Fix for bug #59313, applies to master)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by schlotter (Submitted the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.


    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-10-12 goldsimon StatusNone Need Info
        Assigned toNone goldsimon
    2021-10-15 schlotter Attached File- Added 0001-PATCH-Fix-bug-59313-Possible-faulty-behavior-in-mqtt-master.patch, #52100
    2021-10-14 schlotter Attached File- Added 0001-Fix-bug-59313-Possible-faulty-behavoir-in-mqtt_close.patch, #52099

    Back to the top

    Powered by Savane 3.12.
    Corresponding source code