AVR Downloader/UploaDEr - Patches: patch #10154, Update to serial code management...
You are not allowed to post comments on this tracker with your current authentication level.
patch #10154: Update to serial code management for custom connection parameters
Submitter: | Dawid Buchwald <dawidbuchwald> | ||
Submitted: | Wed 01 Dec 2021 03:47:48 PM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | In Progress | Privacy: | Public |
Assigned to: | None | Open/Closed: | Open |
Jump to the original submission
Sat 04 Dec 2021 07:55:47 PM UTC, comment #9: |
Joerg Wunsch <joerg_wunsch>![]() |
Sat 04 Dec 2021 07:38:29 PM UTC, comment #8:
|
Dawid Buchwald <dawidbuchwald>![]() |
Sat 04 Dec 2021 07:27:08 PM UTC, comment #7:
|
Dawid Buchwald <dawidbuchwald>![]() |
Sat 04 Dec 2021 05:15:16 PM UTC, comment #6:
|
Joerg Wunsch <joerg_wunsch>![]() |
Sat 04 Dec 2021 05:11:11 PM UTC, comment #5:
|
Joerg Wunsch <joerg_wunsch>![]() |
Sat 04 Dec 2021 01:18:04 PM UTC, comment #4:
|
Dawid Buchwald <dawidbuchwald>![]() |
Sat 04 Dec 2021 01:14:02 PM UTC, comment #3:
|
Dawid Buchwald <dawidbuchwald>![]() |
Sat 04 Dec 2021 12:19:57 AM UTC, comment #2: It also looks a bit abusive to add flags to the setspeed() method. If there was a new setcflags() method then it could just be not called for all drives that don't need to change the cflags, and none of the drivers would need to change at all (default would apply if setcflags() is not called).
|
David Sainty <dsainty> |
Fri 03 Dec 2021 10:10:45 PM UTC, comment #1: I wonder whether we could get around those
|
Joerg Wunsch <joerg_wunsch>![]() |
Wed 01 Dec 2021 03:47:48 PM UTC, original submission:
As described in an e-mail sent to AVRDUDE developers mailing list, the purpose of this patch is to enable custom connection parameters for serial connection. This will be required by upcoming SerialUPDI driver. |
Dawid Buchwald <dawidbuchwald>![]() |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2021-12-03 | joerg_wunsch | Status | None | ![]() |
In Progress |
2021-12-01 | dawidbuchwald | Attached File | - | ![]() |
Added serial_params.patch, #52398 |
Carbon-Copy | - | ![]() |
Added dawidbuchwald |
OK, you're correct, union pinfo is not initialized.
Dragging all that into pgm is probably not such a good idea, not sure.
Nevertheless, I'd vote for some simplification in the cflags handling, as we'll for sure never use all combinations of the cflags bits, so why move all these details out from the serial code into the programmer implementations (even if its only done by a DEFAULT macro)?
Should we ever need more than 8N1 and 8E2, we could simply add that.