patchlwIP - A Lightweight TCP/IP stack - Patches: patch #10156, redefine many vars as...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #10156: redefine many vars as "static"

Submitter:  Florian La Roche <flaroche>
Submitted:  Tue 07 Dec 2021 08:16:41 AM UTC
 
Category:  None Priority:  3 - Low
Status:  Done Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Closed
Planned Release:  None
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Thu 30 Dec 2021 09:14:04 PM UTC, comment #4: 

Pushed, thanks for the patch.

Simon Goldschmidt <goldsimon>
Project Administrator
Tue 07 Dec 2021 02:57:02 PM UTC, comment #3: 

Convenience upload of a new patch file with "netconn_deleted"
also as "static" and no change for fsdata.c.

best regards,

Florian La Roche

(file #52449)

Florian La Roche <flaroche>
Tue 07 Dec 2021 02:29:05 PM UTC, comment #2: 

The variable "netconn_deleted" in api_msg.c is also a candidate for "static".

Thomas Mueller <tmu>
Tue 07 Dec 2021 01:56:10 PM UTC, comment #1: 

Most of the changes seem correct.

You mustn't touch 'fsdata.c' however: it is generated by the makefsdata tool. Plus you cannot really be sure how that file is used, so I'm not sure it's OK for everyone to change the code generated by the makefsdata tool to add 'static' there.

Simon Goldschmidt <goldsimon>
Project Administrator
Tue 07 Dec 2021 08:16:41 AM UTC, original submission:  

The static code checker "sparse" flags vars that are not
defined in public headers as candidates to be "static".
I am no expert for lwip, but I think they can indeed all be
marked static and should not be accessed from outside and
added to header files.

best regards and thanks for lwip,

Florian La Roche

Florian La Roche <flaroche>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #52449:  lwip-static-new.patch added by flaroche (5KiB - text/x-patch)
file #52447:  lwip-static.patch added by flaroche (6KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by tmu (Posted a comment)
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by flaroche (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-12-30 goldsimon Open/ClosedOpen Closed
    2021-12-30 goldsimon StatusNone Done
        Assigned toNone goldsimon
    2021-12-07 flaroche Attached File- Added lwip-static-new.patch, #52449
    2021-12-07 flaroche Attached File- Added lwip-static.patch, #52447

    Back to the top


    Powered by Savane 3.9