lwIP - A Lightweight TCP/IP stack - Patches: patch #5811, Fix negative statistical counter...
You are not allowed to post comments on this tracker with your current authentication level.
patch #5811: Fix negative statistical counter display
Submitter: | Tai-hwa Liang <atliang> | ||
Submitted: | Thu 22 Mar 2007 01:46:29 AM UTC | ||
Category: | None | Priority: | 3 - Low |
Status: | Done | Privacy: | Public |
Assigned to: | fbernon | Open/Closed: | Closed |
Planned Release: | None |
Jump to the original submission
Thu 22 Mar 2007 04:38:58 PM UTC, comment #7: |
Frédéric Bernon <fbernon> |
Thu 22 Mar 2007 10:24:36 AM UTC, comment #6: OK |
Kieran Mansley <kieranm> |
Thu 22 Mar 2007 10:06:00 AM UTC, comment #5: I already got the problem, even if I don't use every day LWIP_STATS - and never in production - with some counters (xmit & recv if I remember), which can overflow very fast.
|
Frédéric Bernon <fbernon> |
Thu 22 Mar 2007 09:56:28 AM UTC, comment #4: Is it something that you (or others?) would find useful? If so, I can't see any reason to object, but I wouldn't worry about it if no one has asked for it. |
Kieran Mansley <kieranm> |
Thu 22 Mar 2007 09:54:19 AM UTC, comment #3: Ok, but a simple idea :
|
Frédéric Bernon <fbernon> |
Thu 22 Mar 2007 09:04:12 AM UTC, comment #2: I think go ahead with this patch as it stands if you're happy with it Frederic. The issue you followed up with is essentially another problem, which we can do something about later if required. |
Kieran Mansley <kieranm> |
Thu 22 Mar 2007 08:26:36 AM UTC, comment #1: Seems good for me for most (and because all stats fields are actually in u16_t). But sometimes, a negative value can indicate a problem in the stack ("two dec for 1 inc" by example). Perhaps it will be usefull to use s32_t or u32_t if you reach limits?
|
Frédéric Bernon <fbernon> |
Thu 22 Mar 2007 01:46:29 AM UTC, original submission:
The attached patch changed the format string in various stats_display_XXX() from signed to unsigned.
|
Tai-hwa Liang <atliang> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-03-22 | fbernon | Status | None | Done | |
Open/Closed | Open | Closed | |||
2007-03-22 | fbernon | Assigned to | None | fbernon | |
2007-03-22 | atliang | Attached File | - | Added stats.c.patch, #12230 |
Powered by Savane 3.13-caa5.
Corresponding source code
Good for me, and commit in CVS.
See CHANGELOG if you need u32_t counters.