AVR Downloader/UploaDEr - Patches: patch #6543, serial-over-tcpip support for...
You are not allowed to post comments on this tracker with your current authentication level.
patch #6543: serial-over-tcpip support for cygwin
Submitter: | Janos Sallai <sallai> | ||
Submitted: | Thu 19 Jun 2008 09:25:02 PM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | Postponed | Privacy: | Public |
Assigned to: | joerg_wunsch | Open/Closed: | Open |
Tue 17 Feb 2009 01:15:25 PM UTC, comment #1: |
Joerg Wunsch <joerg_wunsch>![]() ![]() |
Thu 19 Jun 2008 09:25:02 PM UTC, original submission:
Attached is a patch against the current CVS head (20080619) that adds serial-over-tcpip support if avrdude is built for cygwin.
|
Janos Sallai <sallai> |
Attached Files
file #15878: avrdude-5.6cvs20080619-cygwin-net-serial.patch added by sallai (10KiB - application/octet-stream)
Depends on the following items: None found
Items that depend on this one: None found
Carbon-Copy List
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2009-02-17 | joerg_wunsch | Status | None | ![]() |
Postponed |
Assigned to | None | ![]() |
joerg_wunsch | ||
2008-06-19 | sallai | Attached File | - | ![]() |
Added avrdude-5.6cvs20080619-cygwin-net-serial.patch, #15878 |
Carbon-Copy | - | ![]() |
Added sallai |
Besides mixing some unrelated (and meanwhile obsolete) patches
into the actual patch, there is one fundamental issue with
this patch: it removes the -mno-cygwin option from CFLAGS
for Cygwin builds. However, -mno-cygwin has been explicitly
added to allow Win32-API-only builds (i.e. MinGW32 builds)
even when building under Cygwin, so no dependency to
cygwin1.dll is required. As far as I know, this feature is
crucial to the way the WinAVR build environment works.
For that reason, adding a native Cygwin build should be
implemented as a configure option (like --enable-native-cygwin),
defaulting to the current way (i.e. --disable-native-cygwin).
This is an acceptance requirement.
Also, as Cygwin basically offers a Posix-compliant API, I
think it would be better to massage the build system so
native Cygwin builds just go ahead, and use ser_posix.c
directly, rather than duplicating much of its functionality
in ser_win32.c. This is not a requirement, but a wish that
allows for easier maintenance.
I'd kindly ask to submit a modified patch.