patchAVR Downloader/UploaDEr - Patches: patch #8967, Change ft2xx library to...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8967: Change ft2xx library to ftdi_syncbb instead of libusb

Submitter:  Alexey Reshetnikov <rs_alexey>
Submitted:  Mon 04 Apr 2016 12:15:05 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open

Mon 04 Apr 2016 08:59:27 PM UTC, comment #1: 

Well, from a licensing point of view, it's somewhat questionable
whether we'd really like to introduce a dependency on a
closed-source library in code licensed under GPL.  Such
dependencies are always tolerable if the library qualifies
as a "system library" (otherwise, you could not use GPL
software on a closed-source OS), but ftd2xx would certainly
not qualify as such.

Second, there are a number of platforms AVRDUDE supports
where libftd2xx is not available at all (*BSD, Solaris).

I'd like to see the real benefit of such an implementation
before having that in the code.  However, it makes more sense
to discuss that on the mailing list rather than in a patch
tracker.  In particular, your submission suggests the
existing implementation were less stable, so we certainly
ought to fix that.  (OK, the signed driver for Windows is
accepted as a benefit.)

Finally, some stylistic issues:

  • If at all, the use of ftd2xx must be completely optional,

so people who cannot or don't want to install it don't lose
any functionality.  Replacing the existing ft245r.c
implementation is thus not acceptabel.


#elif defined(HAVE_LIBFTDI)&&(defined(HAVE_USB_H)||defined(HAVE_LUSB0_USB_H))


  • Spaces and braces are welcome. ;-)


  • If you wrote the file, please add your name in the copyright

header.

  • In the comment in ftd2xx_initialize, there are non-ASCII,

non-ISO8859-1, non-UTF-8 characters. ('\x93', '\x94')


Joerg Wunsch <joerg_wunsch>
Group administrator
Mon 04 Apr 2016 12:15:05 PM UTC, original submission:  

FT2XX is more stable and drivers for windows is signed.
This patch changes libusb to ft2xx to ftdi_syncbb (FT245R and FT232R).

To compile you need:
1. patch sources
2. execute aclocal
3. autoconf
4. update config.guess to the newest
5. configure && make


 

Alexey Reshetnikov <rs_alexey>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #36833:  avrdude-6.3-diff.tar.gz added by rs_alexey (7KiB - application/gzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by joerg_wunsch (Posted a comment)
  • -email is unavailable- added by rs_alexey (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-04-04 rs_alexey Attached File- Added avrdude-6.3-diff.tar.gz, #36833

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code