lwIP - A Lightweight TCP/IP stack - Patches: patch #9555, Add MDNS probing
You are not allowed to post comments on this tracker with your current authentication level.
patch #9555: Add MDNS probing
Submitter: | Jens Nielsen <deft> | ||
Submitted: | Sun 28 Jan 2018 07:41:50 AM UTC | ||
Category: | apps | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | goldsimon | Open/Closed: | Closed |
Planned Release: | 2.1.0 |
Jump to the original submission
Tue 03 Jul 2018 06:49:15 PM UTC, comment #20: |
Simon Goldschmidt <goldsimon> |
Tue 03 Jul 2018 10:16:06 AM UTC, comment #19: Yes, sorry I meant to go through the code and remaining todos and do some tests but I think it looks good. I'll open a new patch if I find something useful to share.
|
Jens Nielsen <deft> |
Tue 03 Jul 2018 08:48:56 AM UTC, comment #18: OK, so I'll close this as done. Please reopen if this is wrong. |
Simon Goldschmidt <goldsimon> |
Thu 28 Jun 2018 08:13:51 PM UTC, comment #17: I've finally merged your patch and added some cleanup on top.
|
Simon Goldschmidt <goldsimon> |
Fri 22 Jun 2018 08:44:09 PM UTC, comment #16: Actually, in this case I find it easier to review the squashed version to see what's changed why. I'll still need some time to review but overall it looks good I think.
|
Simon Goldschmidt <goldsimon> |
Fri 22 Jun 2018 09:59:40 AM UTC, comment #15: Attaching MDNS-probing-squashed.patch which contains a rebased and squashed version of all the other patches. "mdns probe test.pcap" demonstrates some of my tests, first 192.168.5.26 starts and registers its names and then I try to start up 192.168.5.62 with different name conflicts (and once without conflict in the end). The responses from .26 indicating conflict are sent unicast so they can't be seen here since the capture is taken on my pc, but you can see my "conflict resolver" function adding the "(2)" to the name and restarting a new series of probes.
|
Jens Nielsen <deft> |
Fri 22 Jun 2018 06:28:51 AM UTC, comment #14: Sure, I also see the patches doesn't apply on latest master anymore, I will squash and rebase and get back with a new patch once I've done some tests.
|
Jens Nielsen <deft> |
Thu 14 Jun 2018 11:07:36 AM UTC, comment #13: Reading through this patch again, I'm confused. I even don't know which one of the attached files to check.
|
Simon Goldschmidt <goldsimon> |
Wed 13 Jun 2018 05:47:35 PM UTC, comment #12: Yes I noticed 2.1.0 is getting closer, hence the question ;) If you have time to look at it that would be super, unfortunately I will be out of office until mid next week but if you need anything else from me I'd be happy to help |
Jens Nielsen <deft> |
Tue 12 Jun 2018 08:29:12 PM UTC, comment #11: Well, you might have noticed leftovers for 2.1.0 are decreasing. We are (hopefully) talking about days not weeks here. We really need a decision here, anyway, so I hope I can find the time to have a look at this the next days ;-) |
Simon Goldschmidt <goldsimon> |
Tue 12 Jun 2018 02:39:45 PM UTC, comment #10: Hi guys I know you're all busy and I don't want to nag, but for my own project planning purposes would there be any chance of getting this in the next release?
|
Jens Nielsen <deft> |
Sun 18 Feb 2018 01:48:59 PM UTC, comment #9: Oops I realize I forgot to upload the two rename functions I promised in comment 6, adding patch 6 with the following addition to the api:
|
Jens Nielsen <deft> |
Thu 08 Feb 2018 11:38:13 AM UTC, comment #8: I've reverted the accidental commit d6e58d02a619813a4187ab53ab0ffc2f0b864ad7 for now. |
Simon Goldschmidt <goldsimon> |
Tue 06 Feb 2018 08:09:30 PM UTC, comment #7: Erik, it seems you accidentally pushed one patch, should we revert it? |
Simon Goldschmidt <goldsimon> |
Tue 06 Feb 2018 07:31:39 PM UTC, comment #6: Hi Axel,
|
Jens Nielsen <deft> |
Tue 06 Feb 2018 03:00:42 AM UTC, comment #5: Hi,
|
Axel Lin <axellin> |
Fri 02 Feb 2018 10:22:49 AM UTC, comment #4: Oops, it seems I pushed the first patch just now when I was fixing another thing.
|
Erik Ekman <yarrick> |
Mon 29 Jan 2018 08:04:33 AM UTC, comment #3: Ah right, I think the NULL dereference is copypasted from mdns_announce, I'll fix both
|
Jens Nielsen <deft> |
Sun 28 Jan 2018 08:36:23 PM UTC, comment #2: Thanks, this looks very promising!
|
Erik Ekman <yarrick> |
Sun 28 Jan 2018 08:30:10 PM UTC, comment #1: An idea regarding the api, the user saying "all services are added, go ahead" call isn't really needed, that was just to prevent a stream of announce messages at startup, right? Now I can just (re-)start the timer when the netif or a service is added and assuming all services are added before the timer expires we get the same result. Otherwise the worst thing that will happen is that we send some unnecessary probes but in the end we have still probed all records for uniqueness, with a bit less confusing api.
|
Jens Nielsen <deft> |
Sun 28 Jan 2018 07:41:50 AM UTC, original submission:
Hi
|
Jens Nielsen <deft> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 16 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-07-03 | goldsimon | Status | In Progress | Done | |
Open/Closed | Open | Closed | |||
2018-06-22 | goldsimon | Status | None | In Progress | |
Assigned to | None | goldsimon | |||
Planned Release | None | 2.1.0 | |||
2018-06-22 | deft | Attached File | - | Added 0006-MDNS-add-rename-functions-for-netif-and-services.patch, #44413 | |
Attached File | - | Added mdns probe test.pcap, #44414 | |||
Attached File | - | Added MDNS-probing-squashed.patch, #44415 | |||
2018-01-29 | deft | Attached File | - | Added 0003-Populate-MDNS-probes-authoritative-section_v2.patch, #43103 | |
Attached File | - | Added mdns probe v2.pcap, #43104 | |||
Attached File | - | Added 0005-MDNS-minor-fixes-and-documentation.patch, #43105 | |||
2018-01-28 | deft | Attached File | - | Added 0004-Remove-superfluous-mdns_resp_start-api.patch, #43100 | |
2018-01-28 | deft | Attached File | - | Added 0001-MDNS-send-probes-to-verify-domain-before-use.patch, #43096 | |
Attached File | - | Added 0002-Add-callback-to-user-to-notify-result-of-mdns-probe.patch, #43097 | |||
Attached File | - | Added 0003-Populate-MDNS-probes-authoritative-section.patch, #43098 | |||
Attached File | - | Added mdns probe.pcap, #43099 |
Powered by Savane 3.13-f8d8.
Corresponding source code
Right. I copied the other existing places of similar code. This could be changed, but I wanted all occurrences to be equal.