patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9844, Sockets: Unit tests and apps...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9844: Sockets: Unit tests and apps corrections

Submitter:  Joan Lledó <jllledo>
Submitted:  Sat 10 Aug 2019 10:12:10 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Closed
Planned Release:  None

Sun 11 Aug 2019 06:15:42 PM UTC, comment #1: 

Applied, thanks for the patch.

Simon Goldschmidt <goldsimon>
Group administrator
Sat 10 Aug 2019 10:12:10 AM UTC, original submission:  

1.- src/apps/lwiperf/lwiperf.c:
  - Line 773: Calls htonl() but lwip/inet.h is not included
  - There are other apps and unit tests where htons and pals are being called w/o
    including lwip/inet.h

2.- test/unit/api/test_sockets.c:
  - Line 156: write() could be declared by external socket headers. Call lwip_write()
    instead.
  - Line 333: it expects fcntl() to return 6, but O_RDWR could have another value if
    external socket headers are present. Replace 6 by O_RDWR.

3.- apps/tftp/tftp.c: recv() could be declared by external socket headers. Rename it to
    tftp_recv()
  - Lines 243 and 471

More info at:

https://lists.nongnu.org/archive/html/lwip-devel/2019-07/msg00001.html

Joan Lledó <jllledo>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by jllledo (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-08-11 goldsimon StatusNone Done
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2019-08-10 jllledo Attached File- Added 0002-Sockets-Unit-tests-and-apps-corrections.patch, #47318

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code