lwIP - A Lightweight TCP/IP stack - Patches: patch #9876, PPP: Const-correctness fixes,...
You are not allowed to post comments on this tracker with your current authentication level.
patch #9876: PPP: Const-correctness fixes, pointer types for buffers & couple minor tweaks
Submitter: | Freddie Chopin <freddie_chopin> | ||
Submitted: | Thu 05 Dec 2019 09:25:38 PM UTC | ||
Category: | PPP | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | gradator | Open/Closed: | Closed |
Planned Release: | None |
Tue 20 Oct 2020 03:51:15 AM UTC, comment #4: |
Sylvain Rochet <gradator> |
Sat 07 Dec 2019 12:14:50 PM UTC, comment #3: Hmm, I'm undecided. It's an API change, after all, and a rather cosmetic one... Maybe we can wait for the next "big" release for such a change.
|
Simon Goldschmidt <goldsimon> |
Fri 06 Dec 2019 07:07:33 AM UTC, comment #2:
|
Freddie Chopin <freddie_chopin> |
Thu 05 Dec 2019 11:14:50 PM UTC, comment #1: Well… erm… I have mixed feelings about an API change just to change a pointer type (void* and u8_t* is basically the same thing) and adding some const hints to compiler. It does not fix any issue, does not add a feature, does not even prepare to welcome a new feature, in my opinion it is quite close to being just cosmetic and nitpick.
|
Sylvain Rochet <gradator> |
Thu 05 Dec 2019 09:25:38 PM UTC, original submission:
The major part of these patches is changing `u8_t*` to `const void*` for pppos_input_tcpip(), pppos_input() and pppos_output_cb_fn(). There is no good reason to use non-const buffers for these functions (and this is possibly dangerous - why should output callback modify what lwIP gives it or why should lwIP modify in-place what was given by user?).
|
Freddie Chopin <freddie_chopin> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 11 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2020-10-20 | gradator | Status | None | Done | |
Assigned to | None | gradator | |||
Open/Closed | Open | Closed | |||
Summary | Const-correctness fixes, pointer types for buffers & couple minor tweaks | PPP: Const-correctness fixes, pointer types for buffers & couple minor tweaks | |||
2019-12-05 | freddie_chopin | Attached File | - | Added 0005-Remove-trailing-whitespaces-in-pppos_example.c.patch, #48010 | |
Attached File | - | Added 0006-Remove-useless-cast-from-pppos_output_append-and-ppp.patch, #48011 | |||
2019-12-05 | freddie_chopin | Attached File | - | Added 0001-Use-const-void-instead-of-u8_t-in-pppos_input_tcpip.patch, #48006 | |
Attached File | - | Added 0002-Use-const-void-instead-of-u8_t-in-pppos_input.patch, #48007 | |||
Attached File | - | Added 0003-Remove-useless-cast-from-pppos_input_sys.patch, #48008 | |||
Attached File | - | Added 0004-Use-const-void-instead-of-u8_t-in-pppos_output_cb_fn.patch, #48009 | |||
Carbon-Copy | - | Added -email is unavailable- |
Powered by Savane 3.13-02a9.
Corresponding source code
This is not such a big change after all. I have applied all patches, thank you Freddie !