patchLet me illustrate... - Patches: patch #6753, upgrade to xmlwrapp-0.6.0

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6753: upgrade to xmlwrapp-0.6.0

Submitter:  Vaclav Slavik <vslavik>
Submitted:  Mon 23 Feb 2009 04:29:39 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  chicares Open/Closed:  Closed

Sun 19 Apr 2009 08:58:00 PM UTC, comment #1: 

All committed. Discussed in this thread:

http://lists.nongnu.org/archive/html/lmi/2009-04/msg00028.html

Greg Chicares <chicares>
Group administrator
Mon 23 Feb 2009 04:29:39 PM UTC, original submission:  

Attached patches upgrade LMI to take advantage of the new features introduced in xmlwrapp 0.6.0.

The patches:

lmi-xmlwrapp-0.6-autoconf-require.patch

        Bumps configure's dependency on xmlwrapp to require at least
        version 0.6.0. In build system, this allows us to rely on
        separate libxsltwrapp library; other patches add dependency on
        0.6.0's new API, so this is needed for them too.
       
       
lmi-xmlwrapp-0.6-msw-build.patch

        This upgrades xmlwrapp to 0.6.0 on Windows. Unlike my previous
        (unapplied) patch to upgrade to 0.5.1, this one is more
        complicated, because xmlwrapp now uses standard Autotools build
        system and so LMI no longer needs to build it on its own.
       
        I'm not sure if I did the right thing here: should xmlwrapp stay
        in install_miscellanea.make and be installed
        in /opt/lmi/third_party, or should it install
        into /opt/lmi/local like libmxl2 and wx? If the latter, which
        install_*.make file should the rules go into?
       
       
lmi-xmlwrapp-0.6-use-xsltwrapp.patch

        Instead of homegrown XSLT code, use xsltwrapp library. The new
        code doesn't replicate the following parts of xslt_lmi.cpp:
       
            int substitute_entities_copy =
        xmlSubstituteEntitiesDefault(1);
            int load_ext_dtd_default_copy = xmlLoadExtDtdDefaultValue;
            xmlLoadExtDtdDefaultValue = 0;
       
        The former is xmlwrapp's default already. The latter's default
        is 1, but as far as I can tell, no DTD parts are loaded anywhere
        in LMI, so there's no risk of needless network access, is there?
        Perhaps more importantly, if the default should be 0, then I'd
        say it should be 0 globally for all of LMI and not just for
        XSLT transformations, and we should simply call
       
            xml::init::load_external_subsets(false);
       
        sometimes during initialization.


lmi-xmlwrapp-0.6-use-new-api.patch

        Upgrades LMI code to take advantage of new xmlwrapp APIs. In
        particular, removes xml::init (no longer necessary) and replaces
        xml_lmi::child_elements() with xml::node::elements() and
        xml::nodes_view. In input_xml_io.cpp, nodes_view is a tiny bit
        more efficient than the current manually written code (and
        therefore much faster than the commented-out
        child_elements()-based one).

Vaclav Slavik <vslavik>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by chicares (Posted a comment)
  • -email is unavailable- added by vslavik (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-04-19 chicares StatusNone Done
        Assigned toNone chicares
        Open/ClosedOpen Closed
    2009-02-23 vslavik Attached File- Added lmi-xmlwrapp-0.6-autoconf-require.patch, #17506
        Attached File- Added lmi-xmlwrapp-0.6-msw-build.patch, #17507
        Attached File- Added lmi-xmlwrapp-0.6-use-new-api.patch, #17508
        Attached File- Added lmi-xmlwrapp-0.6-use-xsltwrapp.patch, #17509

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code