lwIP - A Lightweight TCP/IP stack - Patches: patch #9554, Multicast filter and IGMPv3...
You are not allowed to post comments on this tracker with your current authentication level.
patch #9554: Multicast filter and IGMPv3 support (MLDv2 for futrue) patch
Submitter: | hanhui <hanhui03> | ||
Submitted: | Sat 27 Jan 2018 09:24:24 AM UTC | ||
Category: | IPv4 | Priority: | 5 - Normal |
Status: | None | Privacy: | Public |
Assigned to: | None | Open/Closed: | Open |
Planned Release: | None |
( Jump to the original submission )
Wed 16 Jan 2019 07:19:06 PM UTC, comment #12: |
Simon Goldschmidt <goldsimon>![]() |
Wed 16 Jan 2019 05:03:16 PM UTC, comment #11: In fact, I added a mcast.c, this file is a complete ipv4, ipv6 multicast filter, this file has a large amount of code, so the patch looks huge, I try to split into several small patches. |
hanhui <hanhui03> |
Wed 16 Jan 2019 04:55:30 PM UTC, comment #10: Uhm, I still have a todo to split this work here up into multiple smaller commits for review. So with the new work you mentioned, does it make that todo of mine redundant? |
Simon Goldschmidt <goldsimon>![]() |
Wed 16 Jan 2019 04:32:41 PM UTC, comment #9: I will submit another patch in the near future. This patch is very big, because I have to implement a complete multicast filter, ipv4, ipv6, and then set up a more robust multicast socket interface (setsockopt, getsockopt). To achieve full IGMPv3 and MLDv2, I even support vif to support standard PIM multicast routing. |
hanhui <hanhui03> |
Mon 17 Dec 2018 06:58:58 PM UTC, comment #8: This is still on my list. Unfortunately, the attached patch was somehow not in a state to just apply it. |
Simon Goldschmidt <goldsimon>![]() |
Mon 17 Dec 2018 02:31:42 PM UTC, comment #7: Do someone still work on this? Any chance to have IGMPv3 support soon in lwIP? Any help is required? |
David GIRAULT <dgirault> |
Fri 29 Jun 2018 08:57:26 PM UTC, comment #6: I just saw that the manually rebased patch doesn't compile:
|
Simon Goldschmidt <goldsimon>![]() |
Fri 29 Jun 2018 07:43:26 PM UTC, comment #5: I've took the hard way and rebased the patch manually against current git master. I'll upload it here so it doesn't get lost if I should lose track... |
Simon Goldschmidt <goldsimon>![]() |
Sun 25 Feb 2018 11:40:37 AM UTC, comment #4: Okay!I need some time. |
hanhui <hanhui03> |
Fri 23 Feb 2018 11:32:09 AM UTC, comment #3: I can't apply the patch. Possibly because this is a file-only patch and the sources have changed by now (don't know which version you used to create the patch). Could you create a patch from git to ensure this applies? |
Simon Goldschmidt <goldsimon>![]() |
Mon 29 Jan 2018 03:26:55 PM UTC, comment #2: +++ lwip-mcast/src/include/lwip/sockets.h Sat Jan 27 17:16:08 2018
|
Joel Cunningham <jcunningham>![]() |
Sun 28 Jan 2018 09:09:22 PM UTC, comment #1: Wow, that's one big patch! Would it make sense to split this up into independent patches to make reviewing easier? |
Simon Goldschmidt <goldsimon>![]() |
Sat 27 Jan 2018 09:24:24 AM UTC, original submission:
This patch is for <task #14816: Multicast filter and IGMPv3 support>
|
hanhui <hanhui03> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-06-29 | goldsimon | Attached File | - | ![]() |
Added 0001-[v2]-add-multicast-filter-and-IGMPv3-support.patch, #44457 |
2018-06-29 | goldsimon | Attached File | - | ![]() |
Added 0001-add-multicast-filter-and-IGMPv3-support.patch, #44456 |
2018-01-27 | hanhui03 | Attached File | - | ![]() |
Added mcast.patch, #43090 |
Well, in addition, you added lines in many more files, the biggest changes being in sockets.c, followed by igmp.c and api_msg.c.
For me it's easier to review this in single commits that build on each other. I tried that but sadly still haven't found the time, yet.
That's why I ask: what would be changed in your new patch compared to this original patch (or my rebased version in file #44457)?