mainLet me illustrate... - Support: sr #104430, Enable menu items and toolbar...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

sr #104430: Enable menu items and toolbar buttons consistently

Submitter:  Greg Chicares <chicares>
Submitted:  Thu 14 Jul 2005 01:08:45 PM UTC
   
 
Category:  GUI Status:  Done
Priority:  7 - High Severity:  4 - Important
Assigned to:  zeitlin Open/Closed:  Closed

Tue 23 Mar 2010 04:53:58 PM UTC, comment #2: 

The example from the original bug report seems to work fine now (i.e. with wx 2.9 and latest LMI sources from svn) and, AFAICS, this is implemented by IllustrationView::UponUpdateProperties() in illustration_view.cpp, i.e. exactly as it was supposed to.

Are there other known examples where this doesn't work as expected?

Vadim Zeitlin <zeitlin>
Group Member
Sun 02 Oct 2005 11:01:59 PM UTC, comment #1: 

Need to check whether EVT_UPDATE_UI works as expected with doc/view menus: in response to my suggestion to just use it, Greg wrote:

<blockquote>
I've tried that. There are inline comments like this:

        // Needed for (xrc) menu enablement: a
        //   EVT_UPDATE_UI(XRCID("wxID_SAVE"),lmi_wx_app::OnUpdateFileSave)
        // handler fails to update enablement for that menu item.
        // However, enablement of an item with the same ID on the
        // toolbar apparently requires the EVT_UPDATE_UI technique.
        wxDocument* doc = doc_manager_->GetCurrentDocument();
        wxMenuItem* file_save = child_frame->GetMenuBar()->FindItem
            (XRCID("wxID_SAVE")
            );
        if(file_save)
            {
            file_save->Enable(doc && doc->IsModified());
            }

But I find no overall description of the problem, like a scientist's lab
notes that record experiments so as to make them easily reproducible,
accompanied by observations that others can validate or falsify. I could
write such a description if it's not immediately apparent to you what
I've done wrong.

I think I suspected some subtle interaction between doc-view default
processing and wxxrc, but my recollection is not clear.

</blockquote>

Vadim Zeitlin <zeitlin>
Group Member
Thu 14 Jul 2005 01:08:45 PM UTC, original submission:  

For the nonce, certain commands that don't make sense in context
produce pop-up warnings; instead, the applicable GUI elements
should be disabled when it would be senseless to use them.

Example:
  File | New | Census
  Census | Run selected cell
  Illustration | Edit cell
In this context, 'Edit cell' should be inhibited.

Greg Chicares <chicares>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by chicares (Updated the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-08-09 chicares StatusReady For Test Done
        Open/ClosedOpen Closed
    2010-03-23 zeitlin StatusNone Ready For Test
    2006-09-27 chicares Priority5 - Normal 7 - High
    2006-04-27 wboutin CategoryNone GUI
    2005-10-02 zeitlin Assigned toNone zeitlin

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code